[DATA GRID] Fix fullscreen scrolling issues #4477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4477/ |
|
jenkins test this |
snide
changed the title
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4477/ |
chandlerprall
approved these changes
Feb 4, 2021
There was a problem hiding this comment.
chandlerprall is gonna check into (see comment below, it might be fine)
I don't notice any performance impacts from this PR. Having a fullscreen grid is still expensive to render while scrolling, but that isn't introduced by these changes.
Changes LGTM! Tested various examples with this changeset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Solves the worst offender in #4458
Fixes the horizontal scrolling issues that the grid has when it full-screen. It has some performance issues at present that @chandlerprall is gonna check into (see comment below, it might be fine).
Checklist
Props have proper autodocs and playground togglesAdded or updated jest testsChecked for breaking changes and labeled appropriatelyChecked for accessibility including keyboard-only and screenreader modes