Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiText] Fix multiple missing CSS logical properties #6059

Merged
merged 4 commits into from
Jul 18, 2022

Conversation

cee-chen
Copy link
Member

@cee-chen cee-chen commented Jul 18, 2022

Summary

I missed converting a few of these properties in #5895 and #6049 🙈

Before

After

Checklist

  • Checked in direction: rtl and writing-mode: vertical-rl
  • Checked in Chrome, Safari, Edge, and Firefox
  • A changelog entry exists and is marked appropriately

@cee-chen cee-chen requested a review from miukimiu July 18, 2022 18:49
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6059/

Copy link
Contributor

@miukimiu miukimiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

How did we miss that? 😄

There's also one text-align: center that can be converted to use ${logicalTextAlignCSS('center')};.

text-align: center;

@cee-chen
Copy link
Member Author

text-align: center; is the same / there isn't a logical properties equivalent, so I left that alone. No strong preference either way though, in this case I don't think it's likely to change in the future, but it's also maybe useful to include to remind us to use more logical properties in the future 🤔

Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the snapshot update

it's also maybe useful to include to remind us to use more logical properties in the future

Yeah we have the util function so might as well use it. If it ever does change then we can update one place.

@cee-chen cee-chen enabled auto-merge (squash) July 18, 2022 20:54
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6059/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6059/

@cee-chen cee-chen merged commit 4ce0404 into elastic:main Jul 18, 2022
@cee-chen cee-chen deleted the emotion/text branch July 18, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants