Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiTour] Add ability to pass an array of buttons to footerAction #6384

Merged
merged 11 commits into from
Nov 23, 2022
Merged

[EuiTour] Add ability to pass an array of buttons to footerAction #6384

merged 11 commits into from
Nov 23, 2022

Commits on Nov 18, 2022

  1. Add ability to pass an array of buttons in footerAction

    @miukimiu
    miukimiu committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    0794efb View commit details
    Browse the repository at this point in the history

  2. Adding conditional button

    @miukimiu
    miukimiu committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    3b63c40 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2022

  1. Adding CL

    @miukimiu
    miukimiu committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    a97490b View commit details
    Browse the repository at this point in the history

  2. Adding test

    @miukimiu
    miukimiu committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    589e6f6 View commit details
    Browse the repository at this point in the history

  3. Improving demo

    @miukimiu
    miukimiu committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    14fab45 View commit details
    Browse the repository at this point in the history

  4. Added new CL

    @miukimiu
    miukimiu committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    2e4a7d4 View commit details
    Browse the repository at this point in the history

  5. Adding unique anchorRef

    @miukimiu
    miukimiu committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    8a2a926 View commit details
    Browse the repository at this point in the history

  6. Adding unique STORAGE_KEY

    @miukimiu
    miukimiu committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    e53c39c View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2022

  1. [PR feedback] Mobile behavior

    @cee-chen
    cee-chen committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    76dce60 View commit details
    Browse the repository at this point in the history

  2. [PR feedback] unnecessary const declaration 

    - it isn't used in more than one place and it isn't significantly more readable
    @cee-chen
    cee-chen committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    ed67c19 View commit details
    Browse the repository at this point in the history

  3. [PR feedback] Copy/grammar tweaks 

    'Not action driven' is the most opinionated change - apologies if it's unwelcome, I just thought it sounded awkward vs using the word 'passive'
    @cee-chen
    cee-chen committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    61e1283 View commit details
    Browse the repository at this point in the history