Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiSuperSelect] Updated i18n default instructions string #6549

Merged
merged 3 commits into from
Jan 25, 2023
Merged

[EuiSuperSelect] Updated i18n default instructions string #6549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
efcf9fd
Updated i18n default string for EuiSuperSelect.
1Copenut Jan 25, 2023
3d36bd8
Added CHANGELOG file.
1Copenut Jan 25, 2023
67a2a1e
Update upcoming_changelogs/6549.md
1Copenut Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions i18ntokens.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4241,7 +4241,7 @@
},
{
"token": "euiSuperSelect.screenReaderAnnouncement",
"defString": "You are in a form selector and must select a single option.\n Use the up and down keys to navigate or escape to close.",
"defString": "You are in a form selector and must select a single option.\n Use the Up and Down arrow keys to navigate or Escape to close.",
"highlighting": "string",
"loc": {
"start": {
Expand Down Expand Up @@ -6143,4 +6143,4 @@
},
"filepath": "src/components/tree_view/tree_view.tsx"
}
]
]
8 changes: 4 additions & 4 deletions src/components/form/super_select/__snapshots__/super_select.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ exports[`EuiSuperSelect props custom display is propagated to dropdown 1`] = `
class="emotion-euiScreenReaderOnly"
id="euiSuperSelect__generated-id__screenreaderDescribeId"
>
You are in a form selector and must select a single option. Use the up and down keys to navigate or escape to close.
You are in a form selector and must select a single option. Use the Up and Down arrow keys to navigate or Escape to close.
</p>
<div
aria-describedby="euiSuperSelect__generated-id__screenreaderDescribeId"
Expand Down Expand Up @@ -442,7 +442,7 @@ exports[`EuiSuperSelect props more props are propogated to each option 1`] = `
class="emotion-euiScreenReaderOnly"
id="euiSuperSelect__generated-id__screenreaderDescribeId"
>
You are in a form selector and must select a single option. Use the up and down keys to navigate or escape to close.
You are in a form selector and must select a single option. Use the Up and Down arrow keys to navigate or Escape to close.
</p>
<div
aria-activedescendant="1"
Expand Down Expand Up @@ -594,7 +594,7 @@ exports[`EuiSuperSelect props options are rendered when select is open 1`] = `
class="emotion-euiScreenReaderOnly"
id="euiSuperSelect__generated-id__screenreaderDescribeId"
>
You are in a form selector and must select a single option. Use the up and down keys to navigate or escape to close.
You are in a form selector and must select a single option. Use the Up and Down arrow keys to navigate or Escape to close.
</p>
<div
aria-describedby="euiSuperSelect__generated-id__screenreaderDescribeId"
Expand Down Expand Up @@ -745,7 +745,7 @@ exports[`EuiSuperSelect props renders popoverProps on the underlying EuiPopover
class="emotion-euiScreenReaderOnly"
id="euiSuperSelect__generated-id__screenreaderDescribeId"
>
You are in a form selector and must select a single option. Use the up and down keys to navigate or escape to close.
You are in a form selector and must select a single option. Use the Up and Down arrow keys to navigate or Escape to close.
</p>
<div
aria-activedescendant="2"
Expand Down
2 changes: 1 addition & 1 deletion src/components/form/super_select/super_select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ export class EuiSuperSelect<T extends string> extends Component<
<EuiI18n
token="euiSuperSelect.screenReaderAnnouncement"
default="You are in a form selector and must select a single option.
Use the up and down keys to navigate or escape to close."
Use the Up and Down arrow keys to navigate or Escape to close."
/>
</p>
</EuiScreenReaderOnly>
Expand Down
1 change: 1 addition & 0 deletions upcoming_changelogs/6549.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Updated `EuiSuperSelect` screen reader instructions to be more specific