Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SR-only help text to EuiPopover and dependent components. #6589

Merged
merged 20 commits into from
Mar 7, 2023
Merged

Added SR-only help text to EuiPopover and dependent components. #6589

merged 20 commits into from
Mar 7, 2023

Commits on Dec 19, 2022

  1. WIP. Updating EuiPopover for focusable content instructions.

    @1Copenut
    1Copenut committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    5cb12af View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. Merge branch 'main' into feature/screen-reader-dialogue

    @1Copenut
    1Copenut committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    4a5f6a4 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. Added SR-only help text to EuiPopover and dependent components. 

    * Added SR help text to EuiPopover, EuiRange, EuiDualRange.
* Completed preliminary testing with Safari and Firefox, VO screen reader.
* Updated snapshot tests for SR instructions.
    @1Copenut
    1Copenut committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    7232812 View commit details
    Browse the repository at this point in the history

  2. Added CHANGELOG entry.

    @1Copenut
    1Copenut committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    3366a9d View commit details
    Browse the repository at this point in the history

  3. Fixed the EuiSuggest CodeSandbox demo.

    @1Copenut
    1Copenut committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    0b901c3 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. Added i18n to EuiRange. Refactored ARIA logic for simpler reasoning.

    @1Copenut
    1Copenut committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    32a303c View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. Simplified the screen reader message for EuiPopover.

    @1Copenut
    1Copenut committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    87dc3f3 View commit details
    Browse the repository at this point in the history

  2. Removing unneeded type isTabbable.

    @1Copenut
    1Copenut committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    7ea121e View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2023

  1. Update upcoming_changelogs/6589.md 

    Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
    @1Copenut @cee-chen
    1Copenut and cee-chen authored Mar 1, 2023
    Configuration menu
    Copy the full SHA
    dade2f3 View commit details
    Browse the repository at this point in the history

  2. Reducing redundant SR-only help text.

    @1Copenut
    1Copenut committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    3e1adc4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'feature/screen-reader-dialogue' of github.com:1Copenut/… 

    …eui into feature/screen-reader-dialogue
    @1Copenut
    1Copenut committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    030c02b View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2023

  1. Simplified aria-describedby API for EuiSuggest. 

    * Removed extra EuiScreenReaderOnly component.
* Refactoring aria-describedby for EuiSuggest.
    @1Copenut
    1Copenut committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    2b7ddd4 View commit details
    Browse the repository at this point in the history

  2. Renaming EuiSelectable instructions prop.

    @1Copenut
    1Copenut committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    df24be2 View commit details
    Browse the repository at this point in the history

  3. Merging main to resolve EuiSuggest snapshot conflict.

    @1Copenut
    1Copenut committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    a913539 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. Update EuiSuggest instructions to optionally prepend to existing.

    @1Copenut
    1Copenut committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    2afdb27 View commit details
    Browse the repository at this point in the history

  2. Added unit test for custom aria-describedby string.

    @1Copenut
    1Copenut committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    faedbef View commit details
    Browse the repository at this point in the history

  3. Refactored EuiSelectable unit test to correctly find SR-only instruct… 

    …ion text.
    @1Copenut
    1Copenut committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    082150d View commit details
    Browse the repository at this point in the history

  4. Updated screen reader selector with ID.

    @1Copenut
    1Copenut committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    eb0d5f3 View commit details
    Browse the repository at this point in the history

  5. Update src/components/selectable/selectable.tsx 

    Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
    @1Copenut @cee-chen
    1Copenut and cee-chen authored Mar 6, 2023
    Configuration menu
    Copy the full SHA
    d780a2e View commit details
    Browse the repository at this point in the history

  6. Updating unit tests and snapshots for simpler instruction string conc… 

    …atenation.
    @1Copenut
    1Copenut committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    75c8076 View commit details
    Browse the repository at this point in the history