[Emotion] Convert EuiKeyPadMenu
(Menu component only) to Emotion
#6636
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is PR 1/2 to convert
EuiKeyPadMenu
to Emotion. This PR takes care of convertingEuiKeyPadMenu
and a PR will come later to convertEuiKeyPadMenuItem
.Note:
EuiKeyPadMenu
variables were not removed as they are still being used byEuiKeyPadMenuItem
.QA
Remove or strikethrough items that do not apply to your PR.
General checklist
Emotion conversion checklist
- [ ] Checked component playground (class components wrapped inwithEuiTheme
need to passtrue
as the second argument to itspropUtilityForPlayground
insrc-docs/src/views/{component}/playground.js
)shouldRenderCustomStyles()
test was added and passes with parent component and any nestedchildProps
(e.g.tooltipProps
)- [ ] Removed anymount()
ed snapshots in favor ofrender()
or a more specific assertion$euiSize
toeuiTheme.size.base
) No: `EuiKeyPadMenuItem still needs themcalc()
tomathWithUnits
if possible (if mixing different unit types, this may not be possible)- [ ] Added an@warn
deprecation message within theglobal_styling/mixins/{component}.scss
filesrc/components/index.scss
- [ ] Deleted anysrc/amsterdam/overrides/{component}.scss
files (styles within should have been converted to the baseline Emotion styles)- [ ] Wrapped all animations or transitions ineuiCanAnimate
gap
property to add margin between items if using flex-inline
and-block
logical properties (check inline styles as well as CSS)euiComponent
,euiComponent__child
)- [ ] Deleted any modifier classNames or maps if not being used in Kibana. Before doing this step:**/target, **/*.snap, **/*.storyshot
for less noise) foreui{Component}
(case sensitive) to find:Checked in Kibana and the snapshots / style updates are for
EuiKeyPadMenuItem
, notEuiKeyPadMenu
euiBadge
class on a div instead of simply using theEuiBadge
component)- [ ] Documentation pass:- [ ] Converted any remaining.js
docs files to TS- [ ] Misc cleanup of docs code (e.g. combine imports to singlefrom '../src'
, replace<React.Fragment>
with<>
)- [ ] Check for issues in the backlog that could be a quick fix for that component- [ ] Optional component/code cleanup: consider splitting up the component into multiple children if it's overly verbose or difficult to reason about