[EuiInlineEdit] Create placeholder prop for Inline Edit & Friends
#6883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ghtly edit the text color
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6883/ |
11 tasks
cee-chen
reviewed
Jun 29, 2023
cee-chen
reviewed
Jun 29, 2023
cee-chen
reviewed
Jun 29, 2023
cee-chen
reviewed
Jun 29, 2023
cee-chen
reviewed
Jun 29, 2023
cee-chen
reviewed
Jun 29, 2023
cee-chen
reviewed
Jun 29, 2023
cee-chen
reviewed
Jun 29, 2023
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6883/ |
- Reordered placeholder prop within documentation - Update color of placeholder text color to meet contrast ratio guidelines
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6883/ |
cee-chen
approved these changes
Jun 29, 2023
1Copenut
added a commit
to elastic/kibana
that referenced
this pull request
Jul 11, 2023
`eui@83.0.0` ⏩ `83.1.0` --- ## [`83.1.0`](https://github.com/elastic/eui/tree/v83.1.0) - Added `placeholder` prop to `EuiInlineEdit` ([#6883](elastic/eui#6883)) - Added `sparkles` glyph to `EuiIcon` ([#6898](elastic/eui#6898)) **Bug fixes** - Fixed Safari-only bug for single-line row `EuiDataGrid`s, where cell actions on hover would overlap instead of pushing content to the left ([#6881](elastic/eui#6881)) - Fixed `EuiButton` not correctly merging in passed `className`s with its base `.euiButton` class ([#6887](elastic/eui#6887)) - Fixed `EuiIcon` not correctly passing the `style` prop custom `img` icons ([#6888](elastic/eui#6888)) - Fixed multiple components with child props (e.g. `buttonProps`, `iconProps`, etc.) unsetting EUI's Emotion styling if custom `css` was passed to the child props object ([#6896](elastic/eui#6896)) **CSS-in-JS conversions** - Converted `EuiHeader` and `EuiHeaderLogo` to Emotion ([#6878](elastic/eui#6878)) - Removed Sass variables `$euiHeaderDarkBackgroundColor`, `$euiHeaderBorderColor`, and `$euiHeaderBreadcrumbColor` ([#6878](elastic/eui#6878)) - Removed Sass mixin `@euiHeaderDarkTheme` ([#6878](elastic/eui#6878))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6857 || Original PR: #6872
Summary
Creation of the
placeholderprop forEuiInlineEdit.Read Mode:
The
placeholdervalue is displayed inreadModewhen the placeholder is present and nodefaultValueis passed in or ifreadModeValueis empty. Theplaceholdertext will also appear in a light color inreadMode.Edit Mode:
placeholderis passed to theeditModeinput form control.QA
Head over to EuiInlineEdit in staging and ensure you can do the following:
Remove or strikethrough items that do not apply to your PR.
General checklist
@defaultif default values are missing) and playground toggles