Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiAccordion] Improve keyboard accessibility of tabbable children #7064

Merged
merged 6 commits into from
Aug 10, 2023
Merged

[EuiAccordion] Improve keyboard accessibility of tabbable children #7064

merged 6 commits into from
Aug 10, 2023

Commits on Aug 9, 2023

  1. [misc cleanup] Optional chaining syntax

    @cee-chen
    cee-chen committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    d76c33d View commit details
    Browse the repository at this point in the history

  2. [misc cleanup] DRY out forceState === 'open' checks 

    - using a JS getter
    @cee-chen
    cee-chen committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    493cf86 View commit details
    Browse the repository at this point in the history

  3. [EuiAccordion] Manually handle tabbable children on close & re-open

    @cee-chen
    cee-chen committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    2bece39 View commit details
    Browse the repository at this point in the history

  4. Write tests

    @cee-chen
    cee-chen committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    e40a7c1 View commit details
    Browse the repository at this point in the history

  5. changelog

    @cee-chen
    cee-chen committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    60a5ea3 View commit details
    Browse the repository at this point in the history

  6. [misc] Fix EuiCollapsibleNavItem story 

    - this visually broke when I removed the `eui-yScroll` child div - fixing it now
    @cee-chen
    cee-chen committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    9a9ebc2 View commit details
    Browse the repository at this point in the history