-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Emotion] Reduce CSS browser prefixing to supported browsers only #7272
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
bf9a394
Copy Emotion's existing `prefixer` logic
cee-chen e63d421
Add typing + minor syntax changes
cee-chen a05e278
Remove unnecessary `:`/`::` selector prefixes
cee-chen 5ce5159
Remove unnecessary animation/keyframes prefixes
cee-chen 60b45e5
[organization] move js docblock/export up above
cee-chen b180c40
Remove flex CSS prefixes
cee-chen 843c05b
Remove unnecessary transform/transition CSS prefixes
cee-chen ef59862
Remove unnecessary position sticky prefixes
cee-chen 29f7a4f
Remove unnecessary writing-mode prefixes
cee-chen b9c076d
Remove unnecessary columns prefixes
cee-chen 012e6d9
Remove unnecessary text-related prefixes
cee-chen 20a55d4
Remove unnecessary filter/image related prefixes
cee-chen 2840969
Remove unnecessary `inline` logical property prefixes
cee-chen 35b399c
Tweak prefixes for sizing values to only `stretch` values
cee-chen fb1f2bf
Remove unnecessary extra `-moz`/`-ms` prefixes
cee-chen 4d37898
Add more tests + comments for more prefixed CSS
cee-chen 8c31cb0
Add mask tests
cee-chen e0f7dfa
More granular `background-clip` prefixing
cee-chen d596e52
[docs] Update docs site to use prefix plugin + add documentation
cee-chen 7e1ed3e
Update default EUI provider cache and theme provider to use new prefi…
cee-chen 4366d18
[misc] Fix missing color mode label/name
cee-chen 3bfaaf0
Update downstream `EuiThemeProvider` snapshots
cee-chen 9d4bb78
changelog
cee-chen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tkajtoch I'd appreciate your advice on this one - the
stylis
package that we're using to write a custom prefixer plugin for Emotion is a dependency of@emotion/css
and thus should always be present in consumer applications (since@emotion/css
is listed inpeerDependencies
). I'm hesitating as to whether or not that means we need to explicitly list thestylis
dependency in our own package.json, and if we do, whether it should be under eitherdependencies
orpeerDependencies
.What's also a little odd is that Emotion appears to pin its dependency on
stylis
specifically at 4.2.0 without a caret (latest is 4.3.0), so I worry that including our own stylis version would potentially cause weird issues or conflicts with Emotion. 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chatted with Tomasz on this in our sync today - he's good with moving forward with this. If any issues do come up with consumer dependencies, we can absolutely revisit/fix this in the future.