Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiButton][EuiButtonEmpty][EuiButtonIcon] Remove color="ghost" #7296

Merged
merged 9 commits into from
Oct 25, 2023
Merged

[EuiButton][EuiButtonEmpty][EuiButtonIcon] Remove color="ghost" #7296

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e7c29fd
Remove `ghost` color from EUI buttons
cee-chen Oct 18, 2023
b7dc9b4
Clean up props
cee-chen Oct 18, 2023
b5e5a8c
[docs] Remove `ghost` button documentation
cee-chen Oct 18, 2023
be0c695
[docs] Fix other `color="ghost"` button usages
cee-chen Oct 18, 2023
76577f7
[docs] Fix broken sticky bottom bar demo
cee-chen Oct 18, 2023
b95716e
[EuiControlBar] Remove `ghost` colors
cee-chen Oct 18, 2023
d54b47b
changelog
cee-chen Oct 18, 2023
5c871b2
Update mounted snapshot changes caused by `defaultProps` removal
cee-chen Oct 18, 2023
6d6d79b
[docs] Fix `color` prop not correctly showing the default value
cee-chen Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions src-docs/src/views/bottom_bar/bottom_bar_position.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,23 @@
import React from 'react';

import { EuiBottomBar, EuiSpacer, EuiText } from '../../../../src/components';
import { EuiBottomBar, EuiText } from '../../../../src/components';

export default () => {
return (
<>
<div css={{ overflow: 'auto', blockSize: 200 }}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a bonus fix in addition to the ghost changes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! It's in its own separate commit as well 76577f7. I usually add a note to my PR descriptions recommending that folks follow along with changes by commit as I tend to throw in a lot of misc cleanup items in (but I try really hard to keep my git history clean so that optional cleanup items are separate from actual features or main functionality).

TBH I noticed a while back that the demo was broken on prod and was too lazy to fix it then, this PR was a good excuse 😅

<EuiText>
<p>
When scrolling past this example block, the{' '}
<strong>EuiBottomBar</strong> will stick to the bottom of the browser
window (with a 10px offset), but keeps it within the bounds of its
parent.
When scrolling within this example, the <strong>EuiBottomBar</strong>{' '}
will stick to the bottom of scrollable container (with a 10px offset),
but will not scroll with the page itself.
</p>
</EuiText>
<EuiSpacer size="xl" />
<EuiSpacer size="xl" />
<div css={{ blockSize: 400 }} />
<EuiBottomBar position="sticky" bottom={10}>
<EuiText textAlign="center">
<p>Scroll to see!</p>
</EuiText>
</EuiBottomBar>
</>
</div>
);
};