Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiDataGrid] Allow clearing the "Lines per row" input #7338

Merged
merged 5 commits into from
Nov 3, 2023
Merged

[EuiDataGrid] Allow clearing the "Lines per row" input #7338

merged 5 commits into from
Nov 3, 2023

Commits on Nov 3, 2023

  1. [misc setup] DRY out default line count to a var 

    - we'll be doing some number->string typing soon, so might as well DRY it out in the two places it's used
    @cee-chen
    cee-chen committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    51b00d4 View commit details
    Browse the repository at this point in the history

  2. Update UX behavior to allow the local input to update if invalid, but… 

    … not the grid display
    @cee-chen
    cee-chen committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    3efe061 View commit details
    Browse the repository at this point in the history

  3. Allow input to be cleared to empty '' 

    - and set invalid state if empty via `required`

- `Number('')` returns 0 (thanks javascript) so we need to switch the input value type to strings, and convert it back to a number for the `rowHeightsOptions` obj
    @cee-chen
    cee-chen committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    ce1f836 View commit details
    Browse the repository at this point in the history

  4. Rename the internal line count state 

    - to try and make it clearer that it's primarily storing state for the input
    @cee-chen
    cee-chen committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    e009644 View commit details
    Browse the repository at this point in the history

  5. changelog

    @cee-chen
    cee-chen committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    9103de9 View commit details
    Browse the repository at this point in the history