Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] Cell actions redesign #7343

Merged
merged 22 commits into from
Nov 20, 2023

Commits on Nov 16, 2023

  1. [setup] Remove extra __contentWrapper DOM node and move padding/fon…

    …t-size to `__content`
    
    - the content wrapper was only needed for flex alignment of cells, and is no longer needed if we start absolutely positioning cell actions
    
    + move height CSS modifier class to content
    cee-chen committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    785dd57 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f566d54 View commit details
    Browse the repository at this point in the history
  3. Update auto row heights to no longer account for padding

    - not longer needed due to removed wrapper / placement of padding in DOM
    cee-chen committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    903d4fb View commit details
    Browse the repository at this point in the history
  4. Absolutely position and color cell actions based on new designs

    + clarify types docs to note that new icons are far more restrictive in terms of display
    cee-chen committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    cb66d42 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9e32d30 View commit details
    Browse the repository at this point in the history
  6. Switch previous cell animation to a pop up one

    + remove delay on hover - IMO, no need for this at this point since the cell actions do not occlude cell content
    cee-chen committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    70d2683 View commit details
    Browse the repository at this point in the history
  7. Improve cell action hover UI

    cee-chen committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    9bce7a8 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    137f621 View commit details
    Browse the repository at this point in the history
  9. Align the cell expansion popover to the cell actions instead of to th…

    …e cell content
    
    - per 5686 - this allows the popover to cover the cell content
    
    - animation stutters and positioning is a pain if we move the anchor ref around the cell actions - so make it a sibling and add it as a shard
    
    - we override the default `onClickOutside` logic because the popover anchor is not actually around the cell actions node (the wrapping anchor div creates too many CSS layout issues)
    cee-chen committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    7c664d6 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    2443a79 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    3f49668 View commit details
    Browse the repository at this point in the history
  12. Allow cell popovers to expand to larger cell widths

    - to match other screenshot Caroline posted - see the auto height datagrid demos
    cee-chen committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    a1238d5 View commit details
    Browse the repository at this point in the history
  13. Fix missing cell popover opacity transition

    + flash of content on initial load for cell contents being limited by the new inline max-width
    cee-chen committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    006e5a2 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    a0f8685 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    96f765d View commit details
    Browse the repository at this point in the history
  16. Fix misc flaky Cypress failures

    - `.realClick` causes issues on cell actions now due to the new transform animation, switch to `.click`
    
    - not totally what's going on with scrolling realMount, but oh well
    cee-chen committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    5774dba View commit details
    Browse the repository at this point in the history
  17. [PR feedback] Add Inter font stylesheet to Cypress index.html instead…

    … of loading it dynamically
    cee-chen committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    d654516 View commit details
    Browse the repository at this point in the history
  18. [PR feedback] method name

    cee-chen committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    62da584 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    375d5fd View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. Configuration menu
    Copy the full SHA
    d3992f5 View commit details
    Browse the repository at this point in the history
  2. [Design feedback] Workaround for border-radius discrepancy when cell …

    …actions are visible vs not visible
    
    - use a pseudo element to fill the visual gap instead, which respects the animation/hover/display state
    
    - going to dry out the color to a CSS variable here shortly
    cee-chen committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    b044581 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    268fd17 View commit details
    Browse the repository at this point in the history