-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiDataGrid] Cell actions redesign #7343
[EuiDataGrid] Cell actions redesign #7343
Commits on Nov 16, 2023
-
[setup] Remove extra
__contentWrapper
DOM node and move padding/fon……t-size to `__content` - the content wrapper was only needed for flex alignment of cells, and is no longer needed if we start absolutely positioning cell actions + move height CSS modifier class to content
Configuration menu - View commit details
-
Copy full SHA for 785dd57 - Browse repository at this point
Copy the full SHA 785dd57View commit details -
Configuration menu - View commit details
-
Copy full SHA for f566d54 - Browse repository at this point
Copy the full SHA f566d54View commit details -
Update auto row heights to no longer account for padding
- not longer needed due to removed wrapper / placement of padding in DOM
Configuration menu - View commit details
-
Copy full SHA for 903d4fb - Browse repository at this point
Copy the full SHA 903d4fbView commit details -
Absolutely position and color cell actions based on new designs
+ clarify types docs to note that new icons are far more restrictive in terms of display
Configuration menu - View commit details
-
Copy full SHA for cb66d42 - Browse repository at this point
Copy the full SHA cb66d42View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e32d30 - Browse repository at this point
Copy the full SHA 9e32d30View commit details -
Switch previous cell animation to a pop up one
+ remove delay on hover - IMO, no need for this at this point since the cell actions do not occlude cell content
Configuration menu - View commit details
-
Copy full SHA for 70d2683 - Browse repository at this point
Copy the full SHA 70d2683View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bce7a8 - Browse repository at this point
Copy the full SHA 9bce7a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 137f621 - Browse repository at this point
Copy the full SHA 137f621View commit details -
Align the cell expansion popover to the cell actions instead of to th…
…e cell content - per 5686 - this allows the popover to cover the cell content - animation stutters and positioning is a pain if we move the anchor ref around the cell actions - so make it a sibling and add it as a shard - we override the default `onClickOutside` logic because the popover anchor is not actually around the cell actions node (the wrapping anchor div creates too many CSS layout issues)
Configuration menu - View commit details
-
Copy full SHA for 7c664d6 - Browse repository at this point
Copy the full SHA 7c664d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2443a79 - Browse repository at this point
Copy the full SHA 2443a79View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f49668 - Browse repository at this point
Copy the full SHA 3f49668View commit details -
Allow cell popovers to expand to larger cell widths
- to match other screenshot Caroline posted - see the auto height datagrid demos
Configuration menu - View commit details
-
Copy full SHA for a1238d5 - Browse repository at this point
Copy the full SHA a1238d5View commit details -
Fix missing cell popover opacity transition
+ flash of content on initial load for cell contents being limited by the new inline max-width
Configuration menu - View commit details
-
Copy full SHA for 006e5a2 - Browse repository at this point
Copy the full SHA 006e5a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0f8685 - Browse repository at this point
Copy the full SHA a0f8685View commit details -
Configuration menu - View commit details
-
Copy full SHA for 96f765d - Browse repository at this point
Copy the full SHA 96f765dView commit details -
Fix misc flaky Cypress failures
- `.realClick` causes issues on cell actions now due to the new transform animation, switch to `.click` - not totally what's going on with scrolling realMount, but oh well
Configuration menu - View commit details
-
Copy full SHA for 5774dba - Browse repository at this point
Copy the full SHA 5774dbaView commit details -
[PR feedback] Add Inter font stylesheet to Cypress index.html instead…
… of loading it dynamically
Configuration menu - View commit details
-
Copy full SHA for d654516 - Browse repository at this point
Copy the full SHA d654516View commit details -
Configuration menu - View commit details
-
Copy full SHA for 62da584 - Browse repository at this point
Copy the full SHA 62da584View commit details -
Configuration menu - View commit details
-
Copy full SHA for 375d5fd - Browse repository at this point
Copy the full SHA 375d5fdView commit details
Commits on Nov 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d3992f5 - Browse repository at this point
Copy the full SHA d3992f5View commit details -
[Design feedback] Workaround for border-radius discrepancy when cell …
…actions are visible vs not visible - use a pseudo element to fill the visual gap instead, which respects the animation/hover/display state - going to dry out the color to a CSS variable here shortly
Configuration menu - View commit details
-
Copy full SHA for b044581 - Browse repository at this point
Copy the full SHA b044581View commit details -
Configuration menu - View commit details
-
Copy full SHA for 268fd17 - Browse repository at this point
Copy the full SHA 268fd17View commit details