Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiDataGrid] Fix cell popovers not closing on outside grid click #7387

Merged
merged 4 commits into from
Nov 29, 2023
Merged

[EuiDataGrid] Fix cell popovers not closing on outside grid click #7387

merged 4 commits into from
Nov 29, 2023

Commits on Nov 23, 2023

  1. [cleanup] remove now-unnecessary cell close popover check 

    - thanks to the moved anchor behavior, we no longer need this, and it's actually messing up other UX
    @cee-chen
    cee-chen committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    9ae02c4 View commit details
    Browse the repository at this point in the history

  2. Fix cell popovers not closing on outside grid click 

    - I had the DOM markup/hierarchy wrong, so the cell popover was never closing

+ add bonus regresison test for ensuring that clicking other cell actions does not close the popover
    @cee-chen
    cee-chen committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    a86a523 View commit details
    Browse the repository at this point in the history

  3. Fix popover/focus trap bug when clicking cell actions and then outsid… 

    …e popover
    @cee-chen
    cee-chen committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    9f59e72 View commit details
    Browse the repository at this point in the history

  4. [misc UI/UX fix] Prevent cell animation flash for keyboard users 

    - Escape key was causing a flash of animation if the mouse was not already hovered over the cell - this prevents it

- DOM traversal is starting to feel pretty shaky, but not totally sure what to do about that
    @cee-chen
    cee-chen committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    49a1d12 View commit details
    Browse the repository at this point in the history