Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Emotion] Convert EuiColorPicker #7845

Merged

Commits on Jun 24, 2024

  1. Configuration menu
    Copy the full SHA
    4af41b4 View commit details
    Browse the repository at this point in the history
  2. [EuiColorPicker] Convert swatches flex CSS

    - swap margins to gap instead
    cee-chen committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    36e661c View commit details
    Browse the repository at this point in the history
  3. [EuiColorPicker] Clean up unnecessary icon affordance CSS

    - now entirely handled by `EuiFormControlLayout`
    
    + remove ignored `icon` prop being passed to EuiFieldText, does nothing if `controlOnly` is passed
    cee-chen committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    5be8149 View commit details
    Browse the repository at this point in the history
  4. [EuiColorPicker] Convert more nested styles

    - not really worth avoiding the nesting here
    cee-chen committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    a69925e View commit details
    Browse the repository at this point in the history
  5. [EuiColorPicker] Clean up spacing CSS/DOM by switching to flex+gap

    - Allows us to remove `margin`s from `EuiHue`
    - Allows us to remove a bunch of conditional `EuiSpacer`s that didn't account  for every possible permutation
    
    + remove extra `<div>` wrapper in favor of passing `onKeyDown` events directly to child `EuiHue` and `EuiSaturation`
    
    - tweak `EuiHue` to have a single wrapper (to work with flex gap) instead of multiple top level children. DOM shouldn't impact a11y behavior
    
    + fix incorrect `compressed` behavior on secondary input display, compressed is always true for that (vs the popover form control)
    cee-chen committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    e34a84e View commit details
    Browse the repository at this point in the history
  6. [EuiColorPicker] Clean up classNames

    - remove unnecessary vars and just inline them since they only have 1 usage
    
    - remove `.euiColorPicker__swatch-item` - not used anywhere in either EUI or Kibana
    
    - remove `.euiColorPicker__swatchSelect` - not used in Kibana and can be replaced with component className instead in EUI
    cee-chen committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    55d19d9 View commit details
    Browse the repository at this point in the history
  7. Delete Sass files

    cee-chen committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    f21f6cb View commit details
    Browse the repository at this point in the history
  8. [tech debt] Tests

    - convert Enzyme to RTL
    
    - add `shouldRenderCustomStyles`
    
    - update snapshots
    cee-chen committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    437474a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    47731ba View commit details
    Browse the repository at this point in the history
  10. changelog

    cee-chen committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    27fbfbb View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Improve EuiColorPicker story further

    - make it so user input changes the input (easier to QA/test) and also add an onChange action
    
    - allow color/format controls to update the story correctly as expected
    cee-chen committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    8254b86 View commit details
    Browse the repository at this point in the history
  2. Misc secondaryInput enhancements

    - show secondary input automatically if `mode` is set that way
    
    - remove double form control layout wrapper
    - fix clear icon not correctly stacking with invalid icon (needs to be passed to form control layout)
    
    - allow compressed state of input to be controlled when `display` is inline, otherwise default to compressed
    cee-chen committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    55b78f4 View commit details
    Browse the repository at this point in the history