-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Emotion] Convert EuiColorPicker #7845
[Emotion] Convert EuiColorPicker #7845
Commits on Jun 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4af41b4 - Browse repository at this point
Copy the full SHA 4af41b4View commit details -
[EuiColorPicker] Convert swatches flex CSS
- swap margins to gap instead
Configuration menu - View commit details
-
Copy full SHA for 36e661c - Browse repository at this point
Copy the full SHA 36e661cView commit details -
[EuiColorPicker] Clean up unnecessary icon affordance CSS
- now entirely handled by `EuiFormControlLayout` + remove ignored `icon` prop being passed to EuiFieldText, does nothing if `controlOnly` is passed
Configuration menu - View commit details
-
Copy full SHA for 5be8149 - Browse repository at this point
Copy the full SHA 5be8149View commit details -
[EuiColorPicker] Convert more nested styles
- not really worth avoiding the nesting here
Configuration menu - View commit details
-
Copy full SHA for a69925e - Browse repository at this point
Copy the full SHA a69925eView commit details -
[EuiColorPicker] Clean up spacing CSS/DOM by switching to flex+gap
- Allows us to remove `margin`s from `EuiHue` - Allows us to remove a bunch of conditional `EuiSpacer`s that didn't account for every possible permutation + remove extra `<div>` wrapper in favor of passing `onKeyDown` events directly to child `EuiHue` and `EuiSaturation` - tweak `EuiHue` to have a single wrapper (to work with flex gap) instead of multiple top level children. DOM shouldn't impact a11y behavior + fix incorrect `compressed` behavior on secondary input display, compressed is always true for that (vs the popover form control)
Configuration menu - View commit details
-
Copy full SHA for e34a84e - Browse repository at this point
Copy the full SHA e34a84eView commit details -
[EuiColorPicker] Clean up classNames
- remove unnecessary vars and just inline them since they only have 1 usage - remove `.euiColorPicker__swatch-item` - not used anywhere in either EUI or Kibana - remove `.euiColorPicker__swatchSelect` - not used in Kibana and can be replaced with component className instead in EUI
Configuration menu - View commit details
-
Copy full SHA for 55d19d9 - Browse repository at this point
Copy the full SHA 55d19d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for f21f6cb - Browse repository at this point
Copy the full SHA f21f6cbView commit details -
- convert Enzyme to RTL - add `shouldRenderCustomStyles` - update snapshots
Configuration menu - View commit details
-
Copy full SHA for 437474a - Browse repository at this point
Copy the full SHA 437474aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 47731ba - Browse repository at this point
Copy the full SHA 47731baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 27fbfbb - Browse repository at this point
Copy the full SHA 27fbfbbView commit details
Commits on Jun 25, 2024
-
Improve EuiColorPicker story further
- make it so user input changes the input (easier to QA/test) and also add an onChange action - allow color/format controls to update the story correctly as expected
Configuration menu - View commit details
-
Copy full SHA for 8254b86 - Browse repository at this point
Copy the full SHA 8254b86View commit details -
Misc
secondaryInput
enhancements- show secondary input automatically if `mode` is set that way - remove double form control layout wrapper - fix clear icon not correctly stacking with invalid icon (needs to be passed to form control layout) - allow compressed state of input to be controlled when `display` is inline, otherwise default to compressed
Configuration menu - View commit details
-
Copy full SHA for 55b78f4 - Browse repository at this point
Copy the full SHA 55b78f4View commit details