Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upgrade fields on version change #1731

Closed
wants to merge 1 commit into from

Conversation

joshdover
Copy link
Contributor

What is the problem this PR solves?

Non ideal solution to https://github.com/elastic/ingest-dev/issues/1184

We should have a more robust way of ensuring that every ack is delivered.

How does this PR solve the problem?

// Explain HOW you solved the problem in your code. It is possible that during PR reviews this changes and then this section should be updated.

How to test this PR locally

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@joshdover joshdover requested a review from a team as a code owner August 10, 2022 19:20
@joshdover joshdover marked this pull request as draft August 10, 2022 19:20
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 10, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-26T08:20:12.582+0000

  • Duration: 41 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 751
Skipped 1
Total 752

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@juliaElastic
Copy link
Contributor

Did some testing with this change and it has some unintended side effects, see here: #2582 (comment)

@jlind23
Copy link
Contributor

jlind23 commented Aug 24, 2023

Closing this for now.

@jlind23 jlind23 closed this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants