Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17](backport #1978) Update to Go 1.18.7. #2009

Closed
wants to merge 5 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 19, 2022

This is an automatic backport of pull request #1978 done by Mergify.
Cherry-pick of 0b36872 has failed:

On branch mergify/bp/7.17/pr-1978
Your branch is up to date with 'origin/7.17'.

You are currently cherry-picking commit 0b36872.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .go-version

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

(cherry picked from commit 0b36872)

# Conflicts:
#	.go-version
@mergify mergify bot requested a review from a team as a code owner October 19, 2022 18:13
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Oct 19, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 19, 2022

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-02T20:21:33.405+0000

  • Duration: 7 min 24 sec

Test stats 🧪

Test Results
Failed 1
Passed 0
Skipped 0
Total 1

Test errors 1

Expand to view the tests failures

[empty] – test-unit.out.xml
  • no error details
  • Expand to view the stacktrace

     Test report file /var/lib/jenkins/workspace/_server_fleet-server-mbp_PR-2009/src/github.com/elastic/fleet-server/build/test-unit.out.xml was length 0 
    

Steps errors 1

Expand to view the steps failures

test
  • Took 0 min 1 sec . View more details here
  • Description: make junit-report

🐛 Flaky test report

❕ There are test failures but not known flaky tests.

Expand to view the summary

Genuine test errors 1

💔 There are test failures but not known flaky tests, most likely a genuine test failure.

  • Name: [empty] – test-unit.out.xml

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@mergify
Copy link
Contributor Author

mergify bot commented Oct 24, 2022

This pull request has not been merged yet. Could you please review and merge it @cmacknz? 🙏

1 similar comment
@mergify
Copy link
Contributor Author

mergify bot commented Oct 31, 2022

This pull request has not been merged yet. Could you please review and merge it @cmacknz? 🙏

@mergify
Copy link
Contributor Author

mergify bot commented Nov 7, 2022

This pull request has not been merged yet. Could you please review and merge it @cmacknz? 🙏

2 similar comments
@mergify
Copy link
Contributor Author

mergify bot commented Nov 14, 2022

This pull request has not been merged yet. Could you please review and merge it @cmacknz? 🙏

@mergify
Copy link
Contributor Author

mergify bot commented Nov 21, 2022

This pull request has not been merged yet. Could you please review and merge it @cmacknz? 🙏

@cmacknz cmacknz added the Team:Fleet Label for the Fleet team label Nov 21, 2022
@jlind23
Copy link
Contributor

jlind23 commented Nov 21, 2022

@cmacknz any reason why you are assigned to this? Are you the one moving it forward?
cc @kpollich

@cmacknz cmacknz assigned michel-laterman and unassigned cmacknz Nov 21, 2022
@cmacknz
Copy link
Member

cmacknz commented Nov 21, 2022

I originally tried making this change assuming it was easy, but then ran into a collection of build errors and got distracted.

We should follow through with this update to ensure fleet-server on 7.17 has the latest Go security patches.

I am going to pre-emptively assign this to @michel-laterman since it is unlikely that I will have time for it before 7.17.8 is released.

@mergify
Copy link
Contributor Author

mergify bot commented Nov 28, 2022

This pull request has not been merged yet. Could you please review and merge it @michel-laterman? 🙏

@cmacknz
Copy link
Member

cmacknz commented Nov 29, 2022

Closing, duplicate of #2101

@cmacknz cmacknz closed this Nov 29, 2022
@mergify mergify bot deleted the mergify/bp/7.17/pr-1978 branch December 5, 2022 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request Team:Fleet Label for the Fleet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants