Replace all secret references in input map #3086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a more generic approach to go through input objects and replace secret references.
michel-laterman
added
bug
Co-authored-by: Kyle Pollich <kpollich1@gmail.com>
|
SonarQube Quality Gate
|
juliaElastic
approved these changes
Nov 8, 2023
mergify bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
Use a more generic approach to go through input objects and replace secret references. (cherry picked from commit 0718a55) # Conflicts: # internal/pkg/policy/secret.go # internal/pkg/policy/secret_test.go
elasticmachine
pushed a commit
that referenced
this pull request
Dec 6, 2023
) Use a more generic approach to go through input objects and replace secret references. (cherry picked from commit 0718a55)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
Secret references are being missed as they can be embedded in sub objects or arrays as part of the input (or stream) object.
How does this PR solve the problem?
Use a more generic approach to go through input objects and replace secret references.
How to test this PR locally
make testfor the unit test that was added.Or follow the integration setup instructions in #3083
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration files./changelog/fragmentsusing the changelog toolRelated issues