Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bulk_indexer: track all response status codes #177

Merged
merged 3 commits into from
Jun 12, 2024

Use switch/case in bulk_indexer.go too

8eef3f2
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

bulk_indexer: track all response status codes #177

Use switch/case in bulk_indexer.go too
8eef3f2
Select commit
Loading
Failed to load commit list.
GitHub Actions / benchdiff-result succeeded Jun 12, 2024 in 0s

Benchdiff Results

Benchmark Command: go test ./... -run ^ -bench . -count 5 -benchtime 100ms -cpu 1,2 -benchmem

HEAD sha: 8eef3f2

Base sha: 0530a0f

Degraded: false

Details

pkg: github.com/elastic/go-docappender/v2
goos: linux
goarch: amd64

name old time/op (ns/op) ± new time/op (ns/op) ± delta ±
Appender/NoCompression 870.375 3% 868.54 2% ~ (p=1.000 n=4+5)
Appender/NoCompression-2 641.74 17% 521.4 7% -18.75% (p=0.008 n=5+5)
Appender/NoCompressionScaling 913.88 5% 907.62 3% ~ (p=1.000 n=5+5)
Appender/NoCompressionScaling-2 638.92 18% 545.36 11% ~ (p=0.056 n=5+5)
Appender/BestSpeed 962.5 2% 904.68 1% -6.01% (p=0.008 n=5+5)
Appender/BestSpeed-2 787.68 8% 750.6 7% ~ (p=0.310 n=5+5)
Appender/BestSpeedScaling 918.48 1% 907.72 1% -1.17% (p=0.032 n=5+5)
Appender/BestSpeedScaling-2 747.6 6% 924.02 21% ~ (p=0.151 n=5+5)
Appender/DefaultCompression 908.88 1% 912.04 1% ~ (p=0.690 n=5+5)
Appender/DefaultCompression-2 777.58 5% 789.3 10% ~ (p=0.548 n=5+5)
Appender/DefaultCompressionScaling 910.44 1% 916.2 1% ~ (p=0.063 n=5+5)
Appender/DefaultCompressionScaling-2 802.96 6% 747.34 5% ~ (p=0.056 n=5+5)
Appender/BestCompression 1541.2 1% 1530.4 0% ~ (p=0.071 n=5+5)
Appender/BestCompression-2 1375.6 8% 1368.6 5% ~ (p=1.000 n=5+5)
Appender/BestCompressionScaling 1550.8 0% 1545.2 1% ~ (p=0.500 n=5+5)
Appender/BestCompressionScaling-2 1411.2 6% 1433.2 11% ~ (p=0.841 n=5+5)
AppenderError 6872.8 4% 6873.8 4% ~ (p=0.841 n=5+5)
AppenderError-2 4234 10% 4104 17% ~ (p=0.548 n=5+5)
name old speed (MB/s) ± new speed (MB/s) ± delta ±
Appender/NoCompression 148.24 3% 148.556 2% ~ (p=1.000 n=4+5)
Appender/NoCompression-2 202.358 15% 247.696 6% +22.40% (p=0.008 n=5+5)
Appender/NoCompressionScaling 141.272 5% 142.16 3% ~ (p=1.000 n=5+5)
Appender/NoCompressionScaling-2 205.764 17% 237.538 10% ~ (p=0.056 n=5+5)
Appender/BestSpeed 134.056 2% 142.6 1% +6.37% (p=0.008 n=5+5)
Appender/BestSpeed-2 164.258 8% 172.236 7% ~ (p=0.310 n=5+5)
Appender/BestSpeedScaling 140.458 1% 142.118 1% +1.18% (p=0.032 n=5+5)
Appender/BestSpeedScaling-2 172.868 6% 143.43 23% ~ (p=0.151 n=5+5)
Appender/DefaultCompression 141.938 1% 141.446 1% ~ (p=0.690 n=5+5)
Appender/DefaultCompression-2 166.044 5% 164.008 11% ~ (p=0.548 n=5+5)
Appender/DefaultCompressionScaling 141.69 1% 140.798 1% ~ (p=0.063 n=5+5)
Appender/DefaultCompressionScaling-2 160.918 6% 172.848 5% ~ (p=0.056 n=5+5)
Appender/BestCompression 83.694 1% 84.286 0% ~ (p=0.056 n=5+5)
Appender/BestCompression-2 93.99 8% 94.346 5% ~ (p=1.000 n=5+5)
Appender/BestCompressionScaling 83.178 0% 83.484 1% ~ (p=0.500 n=5+5)
Appender/BestCompressionScaling-2 91.536 5% 90.45 10% ~ (p=0.841 n=5+5)
AppenderError 18.776 4% 18.776 4% ~ (p=0.841 n=5+5)
AppenderError-2 30.588 9% 31.738 16% ~ (p=0.548 n=5+5)
name old alloc/op (B/op) ± new alloc/op (B/op) ± delta ±
Appender/NoCompression 494.8 7% 508 5% ~ (p=0.444 n=5+5)
Appender/NoCompression-2 434 11% 396 6% -8.76% (p=0.016 n=5+5)
Appender/NoCompressionScaling 504.6 9% 507 6% ~ (p=0.317 n=5+5)
Appender/NoCompressionScaling-2 432.4 6% 408 6% ~ (p=0.135 n=5+5)
Appender/BestSpeed 278.4 2% 273.4 2% ~ (p=0.056 n=5+5)
Appender/BestSpeed-2 282 5% 282.6 6% ~ (p=0.968 n=5+5)
Appender/BestSpeedScaling 277.6 1% 273.4 2% ~ (p=0.056 n=5+5)
Appender/BestSpeedScaling-2 267.6 2% 277.8 5% ~ (p=0.087 n=5+5)
Appender/DefaultCompression 280.2 1% 279.2 1% ~ (p=0.357 n=5+5)
Appender/DefaultCompression-2 277.6 6% 282.6 5% ~ (p=0.452 n=5+5)
Appender/DefaultCompressionScaling 278.6 1% 279.8 1% ~ (p=0.286 n=5+5)
Appender/DefaultCompressionScaling-2 274 5% 268.75 1% ~ (p=0.317 n=5+4)
Appender/BestCompression 290 0% 289.4 0% ~ (p=0.484 n=5+5)
Appender/BestCompression-2 292 0% 290 6% ~ (p=0.659 n=5+5)
Appender/BestCompressionScaling 290 0% 289.2 1% ~ (p=0.190 n=5+5)
Appender/BestCompressionScaling-2 288.2 5% 287.4 5% ~ (p=0.786 n=5+5)
AppenderError 4124.6 8% 4069.8 7% ~ (p=0.690 n=5+5)
AppenderError-2 4177 5% 4136.8 6% ~ (p=1.000 n=5+5)
name old allocs/op (allocs/op) ± new allocs/op (allocs/op) ± delta ±
Appender/NoCompression 8 0% 8 0% ~ (all equal)
Appender/NoCompression-2 8 0% 8 0% ~ (all equal)
Appender/NoCompressionScaling 8 0% 8 0% ~ (all equal)
Appender/NoCompressionScaling-2 8 0% 8 0% ~ (all equal)
Appender/BestSpeed 8 0% 8 0% ~ (all equal)
Appender/BestSpeed-2 8 0% 8 0% ~ (all equal)
Appender/BestSpeedScaling 8 0% 8 0% ~ (all equal)
Appender/BestSpeedScaling-2 8 0% 8 0% ~ (all equal)
Appender/DefaultCompression 8 0% 8 0% ~ (all equal)
Appender/DefaultCompression-2 8 0% 8 0% ~ (all equal)
Appender/DefaultCompressionScaling 8 0% 8 0% ~ (all equal)
Appender/DefaultCompressionScaling-2 8 0% 8 0% ~ (all equal)
Appender/BestCompression 8 0% 8 0% ~ (all equal)
Appender/BestCompression-2 8 0% 8 0% ~ (all equal)
Appender/BestCompressionScaling 8 0% 8 0% ~ (all equal)
Appender/BestCompressionScaling-2 8 0% 8 0% ~ (all equal)
AppenderError 53 0% 53 0% ~ (all equal)
AppenderError-2 53 0% 53 0% ~ (all equal)