Do not treat $ as escape char in plain strings/regexes #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
force-pushed
the
escaping-the-escaping
branch
7 times, most recently
from
589a14a
to
76733e3
Compare
kvch
force-pushed
the
escaping-the-escaping
branch
from
76733e3
to
75bde6f
Compare
kvch
changed the title
kvch
changed the title
urso
reviewed
Oct 5, 2018
variables.go
Outdated
| @@ -429,9 +429,16 @@ func lexer(in string) (<-chan token, <-chan error) { | |||
| lex <- openToken | |||
| off++ | |||
| varcount++ | |||
| default: // escape any symbol | |||
| case '$': | |||
| if content[off+1] == '{' { // remove $ | |||
There was a problem hiding this comment.
Is this really safe? The guard before the switch checks only tests for off >= len(content), but not off + 1.
Why do we need to check for the pattern $${ ? The idea was to escape the pattern $$ -> $ in general.
urso
approved these changes
Oct 5, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.