Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add explicit go directive #19

Merged
merged 12 commits into from
Jul 26, 2022
Merged

fix: add explicit go directive #19

merged 12 commits into from
Jul 26, 2022

Commits on Jul 21, 2022

  1. fix: add explicit go directive 

    A missing go directive can lead to inconsistent
behaviour between go versions.

See https://go.dev/doc/go1.17#missing-go-directive

Add an explicit directive to target Go 1.17.
    @kruskall
    kruskall committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    8be7d33 View commit details
    Browse the repository at this point in the history

  2. ci: run tests on the two most recent versions of Go

    @kruskall
    kruskall committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    36c8ce9 View commit details
    Browse the repository at this point in the history

  3. ci: replace go scripts with posix compliant scripts

    @kruskall
    kruskall committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    fc45561 View commit details
    Browse the repository at this point in the history

  4. fix: resolve goimports issues

    @kruskall
    kruskall committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    adf3dd7 View commit details
    Browse the repository at this point in the history

  5. ci: remove GO111MODULE env from ci 

    As of Go 1.16 module-aware mode is enabled by default so
GO111MODULE=on is no longer needed.

See https://go.dev/doc/go1.16#go-command

This should also help with forward compatibility as
GOPATH and GO111MODULE will be removed in the future,

See https://github.com/golang/go/wiki/GOPATH#deprecating-and-removing-gopath-development-mode
    @kruskall
    kruskall committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    5d558e0 View commit details
    Browse the repository at this point in the history

  6. ci: fix windows bat script

    @kruskall
    kruskall committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    387a0a4 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2022

  1. test.bat: propagate the status code to the script's exit code 

    Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
    @kruskall @andrewkroh
    kruskall and andrewkroh authored Jul 25, 2022
    Configuration menu
    Copy the full SHA
    9809e1a View commit details
    Browse the repository at this point in the history

  2. lint: set exit status if golint fails

    @kruskall
    kruskall committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    47e9f94 View commit details
    Browse the repository at this point in the history

  3. sh: add set -e to shell scripts

    @kruskall
    kruskall committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    a15ab53 View commit details
    Browse the repository at this point in the history

  4. test.bat: propagate status codes of other commands

    @kruskall
    kruskall committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    1447b3d View commit details
    Browse the repository at this point in the history

  5. ci: replace golint with staticcheck 

    golint is deprecated and this is consistent with what
we're doing in other repositories.
    @kruskall
    kruskall committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    c1313f4 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2022

  1. ci: move lint scripts in the main test script

    @kruskall
    kruskall committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    dba6632 View commit details
    Browse the repository at this point in the history