Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix standalone agent K8s manifest link to include patch level #1344

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

kilfoyle
Copy link
Contributor

@kilfoyle kilfoyle commented Sep 25, 2024

It was reported in Slack that on the Kubernetes install instructions for standalone agent, customers are being directed to 8.15.2 manifest files before they're fully available.

Essentially this link:

curl -L -O https://raw.githubusercontent.com/elastic/elastic-agent/8.15/deploy/kubernetes/elastic-agent-standalone-kubernetes.yaml

Should be:

curl -L -O https://raw.githubusercontent.com/elastic/elastic-agent/8.15.1deploy/kubernetes/elastic-agent-standalone-kubernetes.yaml

I've fixed this by changing the {manifest} variable to include {bare-version} (which is currently set to 8.15.1) rather than {branch} (which is currently set to 8.15).

The screen capture below shows the manifest link as 8.16.0 because this change is going into the main branch. In the public docs, this would be the current patch version, so as I write this that version is currently set to 8.15.1.


Screenshot 2024-09-25 at 11 00 16 AM

Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

…standalone.asciidoc

Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
@kilfoyle kilfoyle requested a review from jmlrt September 25, 2024 14:58
@kilfoyle
Copy link
Contributor Author

@elasticmachine run docs-build

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice approach! LGTM

@kilfoyle kilfoyle merged commit 153b04d into elastic:main Sep 25, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request Sep 25, 2024
* Fix standalone agent K8s manifest link to include patch level

* Update docs/en/ingest-management/elastic-agent/running-on-kubernetes-standalone.asciidoc

Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>

---------

Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
(cherry picked from commit 153b04d)
mergify bot pushed a commit that referenced this pull request Sep 25, 2024
* Fix standalone agent K8s manifest link to include patch level

* Update docs/en/ingest-management/elastic-agent/running-on-kubernetes-standalone.asciidoc

Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>

---------

Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
(cherry picked from commit 153b04d)
kilfoyle added a commit that referenced this pull request Sep 25, 2024
…#1347)

* Fix standalone agent K8s manifest link to include patch level

* Update docs/en/ingest-management/elastic-agent/running-on-kubernetes-standalone.asciidoc

Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>

---------

Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
(cherry picked from commit 153b04d)

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
kilfoyle added a commit that referenced this pull request Sep 25, 2024
…#1348)

* Fix standalone agent K8s manifest link to include patch level

* Update docs/en/ingest-management/elastic-agent/running-on-kubernetes-standalone.asciidoc

Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>

---------

Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
(cherry picked from commit 153b04d)

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants