Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add known issue for AWS S3 performance regression in 8.12 #865

Merged
merged 3 commits into from
Jan 27, 2024
Merged

Add known issue for AWS S3 performance regression in 8.12 #865

merged 3 commits into from
Jan 27, 2024

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented Jan 26, 2024 •
edited
Loading

Adds a known issue for the AWS S3 performance regression described in elastic/beats#37754

@cmacknz cmacknz requested a review from kilfoyle January 26, 2024 20:47
@cmacknz cmacknz self-assigned this Jan 26, 2024
@cmacknz cmacknz requested a review from a team as a code owner January 26, 2024 20:47
@github-actions GitHub Actions
Copy link

A documentation preview will be available soon.

Help us out by validating the Buildkite preview and reporting issues here.
Please also be sure to double check all images to ensure they are correct in the preview.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@mergify Mergify
Copy link

mergify bot commented Jan 26, 2024

This pull request does not have a backport label. Could you fix it @cmacknz? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot removed the backport-skip label Jan 26, 2024
@cmacknz cmacknz requested a review from faec January 26, 2024 20:52
This was referenced Jan 26, 2024
Merged
Closed
kilfoyle
kilfoyle previously approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one super small suggestion.

@cmacknz @kilfoyle
Update docs/en/ingest-management/release-notes/release-notes-8.12.asc…
5759d21 
…iidoc

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
kilfoyle
kilfoyle previously approved these changes Jan 26, 2024
View reviewed changes
@kilfoyle
Copy link
Contributor

@cmacknz I can investigate that failing CI check, but likely not until Monday if that's okay with you. The folks I'd like to ask for advice are currently investigating a separate incident.

@cmacknz
Copy link
Member Author

cmacknz commented Jan 26, 2024

Looks like a Git conflict, let's try running it again first and go from there.

@cmacknz
Copy link
Member Author

cmacknz commented Jan 26, 2024

buildkite test it

@cmacknz cmacknz merged commit 6a059ce into elastic:main Jan 27, 2024
4 checks passed
@cmacknz cmacknz deleted the add-8.12-awss3-known-issue branch January 27, 2024 01:57
mergify bot pushed a commit that referenced this pull request Jan 27, 2024
@cmacknz @mergify
Add known issue for AWS S3 performance regression in 8.12 (#865)
5d361e7 
* Add known issue for S3 performance regression.

* Update docs/en/ingest-management/release-notes/release-notes-8.12.asciidoc

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>

* Change wording slightly.

---------

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
(cherry picked from commit 6a059ce)
@mergify mergify bot mentioned this pull request Jan 27, 2024
Merged
cmacknz added a commit that referenced this pull request Jan 29, 2024
@mergify @cmacknz
Add known issue for AWS S3 performance regression in 8.12 (#865) (#867)
dfa55fd 
* Add known issue for S3 performance regression.

* Update docs/en/ingest-management/release-notes/release-notes-8.12.asciidoc

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>

* Change wording slightly.

---------

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
(cherry picked from commit 6a059ce)

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
zmoog
zmoog reviewed Jan 30, 2024
View reviewed changes
docs/en/ingest-management/release-notes/release-notes-8.12.asciidoc

*Impact* +

If you are using the Elasticsearch output, and your configuration uses a performance preset, switch it to `preset: latency`. If you use no preset or use `preset: custom`, then set `queue.mem.flush.timeout: 1` in your output configuration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmacknz, should we set the queue.mem.flush.timeout to 1 or 1s? Does this make a difference if the output parses it as a time.Duration?

The example values in the docs are in the 1s format.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updating this in #871

Will do the same for Beats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmoog zmoog zmoog left review comments

@kilfoyle kilfoyle kilfoyle approved these changes

@lucabelluccini lucabelluccini Awaiting requested review from lucabelluccini

@faec faec Awaiting requested review from faec

Assignees

@cmacknz cmacknz

Labels
backport-8.12 Team:Elastic-Agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmacknz @kilfoyle @zmoog