Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[system] Add system tests for security data_stream #1069

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Jun 2, 2021

What does this PR do?

  • Adds system tests for the httpjson input in the security data_stream
  • Use common config for pipeline tests

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
    - [ ] If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Related issues

@marc-gr marc-gr force-pushed the security-tests branch 2 times, most recently from 5e2f5d2 to 7a01309 Compare June 2, 2021 09:08
@marc-gr marc-gr mentioned this pull request Jun 2, 2021
43 tasks
@elasticmachine
Copy link

elasticmachine commented Jun 2, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1069 updated

  • Start Time: 2021-06-03T13:21:47.436+0000

  • Duration: 11 min 20 sec

  • Commit: 4ad36af

Test stats 🧪

Test Results
Failed 0
Passed 266
Skipped 0
Total 266

Trends 🧪

Image of Build Times

Image of Tests

Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,2 +0,0 @@
dynamic_fields:
event.ingested: ".*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't this needed? Did it become a default somewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since all of them were the same, I moved it to a test-common-config.yml which is now supported 👍

@marc-gr marc-gr merged commit 18a6edb into elastic:master Jun 3, 2021
@marc-gr marc-gr deleted the security-tests branch June 3, 2021 14:23
james-elastic pushed a commit to james-elastic/integrations that referenced this pull request Jun 30, 2021
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants