-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[o365] Add system tests #1119
[o365] Add system tests #1119
Conversation
1728494
to
c3e0023
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
c3e0023
to
f1025e2
Compare
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just added a quick comment
packages/o365/data_stream/audit/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
* Add system tests * Remove error mapping
* Add system tests * Remove error mapping
What does this PR do?
log
input only used for system tests.o365audit
input, which was inadvertently broken due to the lack of system tests:o365audit
input does not have a rawmessage
field to parse, but ao365audit
object already parsed.api
setting type toyaml
.tenant_names
description and configuration: the option is atext
but was treated like an object, which was causing the tests to break. This was not showing up in tests because the option was not set in the system tests for thelog
input.o365audit
Checklist
changelog.yml
file.manifest.yml
file to point to the latest Elastic stack release (e.g.^7.13.0
).Related issues