Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[o365] Add system tests #1119

Merged
merged 2 commits into from
Jun 15, 2021
Merged

[o365] Add system tests #1119

merged 2 commits into from
Jun 15, 2021

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Jun 11, 2021

What does this PR do?

  • Removes log input only used for system tests.
  • Fixes the pipeline and config for o365audit input, which was inadvertently broken due to the lack of system tests: o365audit input does not have a raw message field to parse, but a o365audit object already parsed.
  • Changes api setting type to yaml.
  • Changes tenant_names description and configuration: the option is a text but was treated like an object, which was causing the tests to break. This was not showing up in tests because the option was not set in the system tests for the log input.
  • Fixes pipeline tests configuration.
  • Removes duplicate pipeline test configs and add a common one.
  • Add system tests for o365audit

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Related issues

@marc-gr marc-gr added bug Something isn't working, use only for issues enhancement New feature or request Team:Security-External Integrations labels Jun 11, 2021
@marc-gr marc-gr force-pushed the o365-system-tests branch 2 times, most recently from 1728494 to c3e0023 Compare June 11, 2021 13:45
@elasticmachine
Copy link

elasticmachine commented Jun 11, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1119 updated

  • Start Time: 2021-06-15T10:19:21.244+0000

  • Duration: 11 min 27 sec

  • Commit: 31f136c

Test stats 🧪

Test Results
Failed 0
Passed 25
Skipped 0
Total 25

Trends 🧪

Image of Build Times

Image of Tests

@marc-gr marc-gr mentioned this pull request Jun 14, 2021
43 tasks
@marc-gr marc-gr marked this pull request as ready for review June 15, 2021 09:37
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just added a quick comment

@marc-gr marc-gr merged commit b6c23f2 into elastic:master Jun 15, 2021
@marc-gr marc-gr deleted the o365-system-tests branch June 15, 2021 11:21
james-elastic pushed a commit to james-elastic/integrations that referenced this pull request Jun 30, 2021
* Add system tests

* Remove error mapping
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
* Add system tests

* Remove error mapping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants