Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zeek] Add NTP and Signature data streams #1515

Merged
merged 2 commits into from
Sep 14, 2021

Conversation

legoguy1000
Copy link
Contributor

@legoguy1000 legoguy1000 commented Aug 10, 2021

What does this PR do?

Adds the NTP and Signature data streams that weren't transfer from elastic/beats#23772 and elastic/beats#24224. Also found that the zeek.connection.id field was being left as an empty object {} so I added a remove for that.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Author's Checklist

  • [ ]

How to test this PR locally

cd integrations/packages/zeek
elastic-package check && elastic-package stack down && elastic-package build && elastic-package stack up -d -v -p default && eval "$(elastic-package stack shellinit)" && elastic-package test  -v --data-streams ntp,signature,connection

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Aug 10, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-09T12:36:47.136+0000

  • Duration: 58 min 38 sec

  • Commit: 3882f90

Test stats 🧪

Test Results
Failed 0
Passed 201
Skipped 0
Total 201

Trends 🧪

Image of Build Times

Image of Tests

@marc-gr
Copy link
Contributor

marc-gr commented Aug 10, 2021

/test

@marc-gr
Copy link
Contributor

marc-gr commented Aug 13, 2021

/test

@legoguy1000 legoguy1000 force-pushed the 1461-zeek-updates branch 3 times, most recently from 1e9c8df to 3a74abd Compare August 16, 2021 23:52
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@jamiehynds jamiehynds added the enhancement New feature or request label Aug 31, 2021
@P1llus
Copy link
Member

P1llus commented Sep 9, 2021

/test

1 similar comment
@P1llus
Copy link
Member

P1llus commented Sep 9, 2021

/test

@P1llus P1llus merged commit e00e0fa into elastic:master Sep 14, 2021
@legoguy1000 legoguy1000 deleted the 1461-zeek-updates branch September 14, 2021 11:19
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
* Add Zeek NTP and Signature data streams

* Fix fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zeek Integration missing
5 participants