-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change snapshot testing version to 7.9.0-SNAPSHOT #202
Conversation
Currently for development the 8.0.0-SNAPSHOT builds are used but the packages that we develop are shipped for 7.9. It is possible that a feature in 8.0 does not exist in 7.9 but we use it in a package. Because of this I think it makes more sense to develop against the version we plan to ship the packages to. This also ties into elastic/package-storage#163 A follow up discussion should happen on what happens after 7.9 is released. Should we develop against 7.9 or 7.10.0-SNAPSHOT?
@mtojek Let me know what you think. Probably also others could chime in like @exekias @ycombinator to see if this is a good change or not. Lets see if CI likes it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
I assume that the same image version will be used by package-registry, package-storage during integration tests?
-
Did you try to use these images? Did it work?
I did test install a few packages but I realised I did not test installing agents. The agent.yml was not up-to-date. Strangely agents don't show up, need to investigate further why and if it works on master. For the changes on package-storage, the discussion is here: elastic/package-storage#163 Agree that also version on the package-registry for testing should be adjusted. |
@mtojek Does enrolling agents for you still work with the commands in the README on master? |
It doesn't because of latest changes in Agent:
The enrollment script must be updated. |
@mtojek Could you take care of fixing the enrollment script? Do devs use it for development? |
This is part of the Elastic Agent, part of Docker image. I can open an issue for Ingest Management in Beats. Devs used to work with standalone instances as it's easier to develop without additional namespaces. Most likely we'll heavily use the containerized Agent in |
@mtojek Got it. @michalpristas for awareness. Should we get this PR in without this changes as it is also broken in master? What I tried on my end is installing some packages which worked but not much more. At the same time if this 7.9 does not work, we probably have a problem. CI also passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the issue with agent is unrelated to your changes, I suppose we can merge this PR. Actually it's good you found the issue with enrollment.
PR approved.
Thanks. BTW an other issue I found that it should be probably |
Based on elastic/integrations#202 standard registry tests should run against 7.9. We should make sure in the future it is run against not only 7.9 but all the different versions.
Based on elastic/integrations#202 standard registry tests should run against 7.9. We should make sure in the future it is run against not only 7.9 but all the different versions.
Currently for development the 8.0.0-SNAPSHOT builds are used but the packages that we develop are shipped for 7.9. It is possible that a feature in 8.0 does not exist in 7.9 but we use it in a package. Because of this I think it makes more sense to develop against the version we plan to ship the packages to. This also ties into elastic/package-storage#163 A follow up discussion should happen on what happens after 7.9 is released. Should we develop against 7.9 or 7.10.0-SNAPSHOT?
Currently for development the 8.0.0-SNAPSHOT builds are used but the packages that we develop are shipped for 7.9. It is possible that a feature in 8.0 does not exist in 7.9 but we use it in a package. Because of this I think it makes more sense to develop against the version we plan to ship the packages to. This also ties into elastic/package-storage#163
A follow up discussion should happen on what happens after 7.9 is released. Should we develop against 7.9 or 7.10.0-SNAPSHOT?