Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change snapshot testing version to 7.9.0-SNAPSHOT #202

Merged
merged 2 commits into from
Jul 29, 2020

Conversation

ruflin
Copy link
Member

@ruflin ruflin commented Jul 28, 2020

Currently for development the 8.0.0-SNAPSHOT builds are used but the packages that we develop are shipped for 7.9. It is possible that a feature in 8.0 does not exist in 7.9 but we use it in a package. Because of this I think it makes more sense to develop against the version we plan to ship the packages to. This also ties into elastic/package-storage#163

A follow up discussion should happen on what happens after 7.9 is released. Should we develop against 7.9 or 7.10.0-SNAPSHOT?

Currently for development the 8.0.0-SNAPSHOT builds are used but the packages that we develop are shipped for 7.9. It is possible that a feature in 8.0 does not exist in 7.9 but we use it in a package. Because of this I think it makes more sense to develop against the version we plan to ship the packages to. This also ties into elastic/package-storage#163

A follow up discussion should happen on what happens after 7.9 is released. Should we develop against 7.9 or 7.10.0-SNAPSHOT?
@ruflin ruflin requested a review from mtojek July 28, 2020 14:23
@ruflin ruflin self-assigned this Jul 28, 2020
@ruflin
Copy link
Member Author

ruflin commented Jul 28, 2020

@mtojek Let me know what you think. Probably also others could chime in like @exekias @ycombinator to see if this is a good change or not.

Lets see if CI likes it.

@elasticmachine
Copy link

elasticmachine commented Jul 28, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #202 updated]

  • Start Time: 2020-07-28T15:02:35.085+0000

  • Duration: 3 min 31 sec

Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I assume that the same image version will be used by package-registry, package-storage during integration tests?

  2. Did you try to use these images? Did it work?

@ruflin
Copy link
Member Author

ruflin commented Jul 28, 2020

I did test install a few packages but I realised I did not test installing agents. The agent.yml was not up-to-date. Strangely agents don't show up, need to investigate further why and if it works on master.

For the changes on package-storage, the discussion is here: elastic/package-storage#163 Agree that also version on the package-registry for testing should be adjusted.

@ruflin
Copy link
Member Author

ruflin commented Jul 28, 2020

@mtojek Does enrolling agents for you still work with the commands in the README on master?

@mtojek
Copy link
Contributor

mtojek commented Jul 29, 2020

It doesn't because of latest changes in Agent:

elastic-agent_1     | 4c520b1e-09f6-479a-8530-bb9ea44f754f
elastic-agent_1     |   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
elastic-agent_1     |                                  Dload  Upload   Total   Spent    Left  Speed
100   339  100   339    0     0  14246      0 --:--:-- --:--:-- --:--:-- 14739
elastic-agent_1     | TEZ3R21uTUJQeTFoanNKSFlPc2Q6WkRhRnBuU3FRbDI4MGVoMkhwTWR6dw==
elastic-agent_1     | The Elastic Agent is currently in BETA and should not be used in production
elastic-agent_1     | Error: connection to Kibana is insecure, strongly recommended to use a secure connection (override with --insecure)
environments_elastic-agent_1 exited with code 1

The enrollment script must be updated.

@ruflin
Copy link
Member Author

ruflin commented Jul 29, 2020

@mtojek Could you take care of fixing the enrollment script? Do devs use it for development?

@mtojek
Copy link
Contributor

mtojek commented Jul 29, 2020

@mtojek Could you take care of fixing the enrollment script? Do devs use it for development?

This is part of the Elastic Agent, part of Docker image. I can open an issue for Ingest Management in Beats.

Devs used to work with standalone instances as it's easier to develop without additional namespaces. Most likely we'll heavily use the containerized Agent in elastic-package test.

@ruflin
Copy link
Member Author

ruflin commented Jul 29, 2020

@mtojek Got it. @michalpristas for awareness.

Should we get this PR in without this changes as it is also broken in master? What I tried on my end is installing some packages which worked but not much more. At the same time if this 7.9 does not work, we probably have a problem. CI also passed.

@mtojek mtojek self-requested a review July 29, 2020 13:12
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the issue with agent is unrelated to your changes, I suppose we can merge this PR. Actually it's good you found the issue with enrollment.

PR approved.

@ruflin ruflin merged commit d90993f into elastic:master Jul 29, 2020
@ruflin ruflin deleted the change-snapshot-version branch July 29, 2020 13:14
@ruflin
Copy link
Member Author

ruflin commented Jul 29, 2020

Thanks. BTW an other issue I found that it should be probably docker-compose -f snapshot.yml -f agent.yml pull to make sure always have the most recent agent image?

ruflin added a commit to ruflin/package-registry that referenced this pull request Jul 29, 2020
Based on elastic/integrations#202 standard registry tests should run against 7.9. We should make sure in the future it is run against not only 7.9 but all the different versions.
ruflin added a commit to elastic/package-registry that referenced this pull request Jul 29, 2020
Based on elastic/integrations#202 standard registry tests should run against 7.9. We should make sure in the future it is run against not only 7.9 but all the different versions.
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
Currently for development the 8.0.0-SNAPSHOT builds are used but the packages that we develop are shipped for 7.9. It is possible that a feature in 8.0 does not exist in 7.9 but we use it in a package. Because of this I think it makes more sense to develop against the version we plan to ship the packages to. This also ties into elastic/package-storage#163

A follow up discussion should happen on what happens after 7.9 is released. Should we develop against 7.9 or 7.10.0-SNAPSHOT?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants