Security detection engine.fix changelog

[djptek]

What does this PR do?

The changelog for the security_detection_engine integration had a distinct format to the sibling integrations. This PR aligns the format with the other integrations. I have NOT updated the changelog by choice.

Checklist

• [X ] I have reviewed tips for building integrations and this pull request is aligned with them.
  - [ ] I have verified that all data streams collect metrics or logs.
  - [ ] I have added an entry to my package's changelog.yml file.
  - [ ] I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

• [ ]

How to test this PR locally

Related issues

Screenshots

[elasticmachine]

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2022-09-19T11:07:29.752+0000

• Duration: 13 min 47 sec

Steps errors

Expand to view the steps failures

Google Storage Download

• Took 0 min 0 sec . View more details here

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

[djptek]

/test

[djptek]

By the way, why this matters: I was checking another PR and did some scripting to validate that changes to changelog.yml matched changes to manifest.yml. This exposed the inconsistency in format as well as the version with 2 distinct descriptions

[terrancedejesus]

@djptek - Hello. TRADE has a custom CLI command that adds the updates to our local integrations repo and then creates the PR. This command automatically adjusts the changelog.yml file, so we will need to adjust this on our side. I will open a PR to adjust this.

Reviewing your changes, I noticed that 8.3.2 was removed, is there any particular reason why or questions I can clear up as well? I have some additional questions as well from this.

• Are there any implications upstream from these changes, such as package-storage formatting with manifests?
• Outside of adjusting the changelog.yml file here, does anything else need adjusted that references this file?

[djptek]

Hi @terrancedejesus I think 8.3.2 may have happened after I started the PR, this was not removed intentionally. The one which I had doubts about was version 0.13.1 since this appeared twice, see first commit

[djptek]

Re the other questions:

• Are there any implications upstream from these changes, such as package-storage formatting with manifests?
• Outside of adjusting the changelog.yml file here, does anything else need adjusted that references this file?

Not sure, but my changes are failing CI (silently) so I suspect something may be amiss

If this PR is noise then I'm fine to close

[terrancedejesus]

Hi @terrancedejesus I think 8.3.2 may have happened after I started the PR, this was not removed intentionally. The one which I had doubts about was version 0.13.1 since this appeared twice, see first commit

I see what you are describing, however I am not sure if this was intentional or not. I would keep it as is, but adjust the formatting of course based on the original issue explained in this PR.

[terrancedejesus]

Not sure, but my changes are failing CI (silently) so I suspect something may be amiss
If this PR is noise then I'm fine to close

Checking the Jenkins job, all checks are passing, so I am surprised to see it failed as well, potentially because the changelog file is not recognized as a change during the tests? If this is the case, the next release we do (v8.4.1) I can adjust this file and see if it will pass.

[terrancedejesus]

I will look to get this fixed by the next release cycle on the TRADE side regarding the output of the changelog entries.

[djptek]

Thanks @terrancedejesus

[botelastic]

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

[botelastic]

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

[botelastic]

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!