Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system tests to kibana package #4444

Merged

Conversation

crespocarlos
Copy link
Contributor

@crespocarlos crespocarlos commented Oct 11, 2022

What does this PR do?

This PR adds system tests to the Kibana package

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Run cd packages/kibana && elastic-package test system

Related issues

(cherry picked from commit 53e25510c8fb15dafb75dabada84f3caa583690a)
@elasticmachine
Copy link

elasticmachine commented Oct 11, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-14T11:08:26.067+0000

  • Duration: 31 min 34 sec

Test stats 🧪

Test Results
Failed 0
Passed 28
Skipped 0
Total 28

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@crespocarlos crespocarlos force-pushed the 4008-kibana-package-system-tests branch from dc8b2a8 to 9f9ffce Compare October 11, 2022 19:12
@crespocarlos crespocarlos changed the title Add system tests for kibana package Add system tests to kibana package Oct 11, 2022
@crespocarlos
Copy link
Contributor Author

/test

@crespocarlos crespocarlos force-pushed the 4008-kibana-package-system-tests branch 3 times, most recently from 0a2b953 to 57cf2e8 Compare October 12, 2022 17:51
@elasticmachine
Copy link

elasticmachine commented Oct 12, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (4/4) 💚 2.783
Classes 100.0% (4/4) 💚 2.783
Methods 94.872% (37/39) 👍 5.06
Lines 87.234% (82/94) 👎 -4.233
Conditionals 100.0% (0/0) 💚

@crespocarlos crespocarlos force-pushed the 4008-kibana-package-system-tests branch 16 times, most recently from 1590824 to 6093629 Compare October 13, 2022 11:25
@crespocarlos crespocarlos force-pushed the 4008-kibana-package-system-tests branch 2 times, most recently from cf14f66 to f920259 Compare October 13, 2022 12:28
@crespocarlos crespocarlos force-pushed the 4008-kibana-package-system-tests branch from f920259 to 8196c20 Compare October 13, 2022 18:57
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

- "./scripts/generate-logs.sh:/generate-logs.sh"
- "${SERVICE_LOGS_DIR}:/var/log"
- "kbn_logs:/kbn_logs"
volumes:
Copy link
Contributor Author

@crespocarlos crespocarlos Oct 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Kibana container is not started with root user, we use a in memory mount. With this mount, log_generation container, which is logged in with root, is able to get the files generated by kibana and copy them to ${SERVICE_LOGS_DIR}

@@ -1,3 +1 @@
ELASTIC_PASSWORD=changeme
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.env doesn't work in the CI env

@crespocarlos crespocarlos marked this pull request as ready for review October 14, 2022 08:41
@crespocarlos crespocarlos requested a review from a team as a code owner October 14, 2022 08:41
@crespocarlos crespocarlos added Integration:kibana Kibana Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services labels Oct 27, 2022
@crespocarlos crespocarlos merged commit 023ebd3 into elastic:main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:kibana Kibana Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Stack Monitoring] Add system tests
3 participants