Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSDB] [Postgres] TSDB Enablement of Datastream - Activity #5457

Merged
merged 20 commits into from
Jun 28, 2023

Conversation

agithomas
Copy link
Contributor

Type of change

  • Enhancement

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@agithomas agithomas requested a review from a team as a code owner March 7, 2023 04:29
@elasticmachine
Copy link

elasticmachine commented Mar 7, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-27T15:37:40.419+0000

  • Duration: 17 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 41
Skipped 0
Total 41

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@agithomas agithomas changed the title Issue 5429 postgresql tsdb [TSDB] [Postgres] TSDB Enablement of Datastream - Activity Mar 7, 2023
@agithomas agithomas mentioned this pull request Mar 8, 2023
22 tasks
@elasticmachine
Copy link

elasticmachine commented Mar 8, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 93.333% (28/30) 👍 8.718
Lines 97.041% (164/169) 👎 -2.033
Conditionals 100.0% (0/0) 💚

ritalwar
ritalwar previously approved these changes Mar 15, 2023
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas agithomas requested a review from ritalwar March 15, 2023 15:33
@agithomas agithomas dismissed ritalwar’s stale review March 15, 2023 15:42

Dismissing the review to prevent accident approval. There exist an issue and it must be resolved

@agithomas
Copy link
Contributor Author

PR blocked on elastic/kibana#153220

@lalit-satapathy
Copy link
Collaborator

PR blocked on elastic/kibana#153220

Need to decide whether its fine to upgrade the package version to 8.8, since the dimension fix above is available in 8.8

@botelastic
Copy link

botelastic bot commented May 3, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label May 3, 2023
@botelastic botelastic bot removed the Stalled label May 11, 2023
@lalit-satapathy
Copy link
Collaborator

@agithomas, Anything pending on this? Can we merge the dimension PRs? 8.8.0 can be added in future PR.

@agithomas agithomas requested a review from a team as a code owner June 27, 2023 12:35
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Please take care of dimension field limits in TSDB default enablement PR.

@agithomas agithomas merged commit dba2af2 into elastic:main Jun 28, 2023
1 check passed
@elasticmachine
Copy link

Package postgresql - 1.15.2 containing this change is available at https://epr.elastic.co/search?package=postgresql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants