Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][PHP-FPM] Lens migration for visualizations to kibana version 8.4.0 #5521

Merged
merged 3 commits into from
Mar 21, 2023
Merged

[O11y][PHP-FPM] Lens migration for visualizations to kibana version 8.4.0 #5521

merged 3 commits into from
Mar 21, 2023

Conversation

harnish-elastic
Copy link
Contributor

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for PHP-FPM integration package

  • Statistics for PHP-FPM Lens migration:

PHP-FPM Dashboards Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Metrics PHP-FPM] Pool 7 0 7 0
[Metrics PHP-FPM] Process 3 1 4 0
  10 1 11 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.4.0 itself.

Related issues

Issues Identified

@harnish-elastic harnish-elastic mentioned this pull request Mar 13, 2023
Closed
5 tasks
@kush-elastic kush-elastic added enhancement New feature or request Integration:php_fpm PHP-FPM v8.4.0 Team:Service-Integrations Label for the Service Integrations team labels Mar 13, 2023
@harnish-elastic harnish-elastic marked this pull request as ready for review March 13, 2023 14:28
@harnish-elastic harnish-elastic requested a review from a team as a code owner March 13, 2023 14:28
@elasticmachine
Copy link

elasticmachine commented Mar 13, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-21T05:06:50.149+0000

  • Duration: 16 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 13, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 100.0% (16/16) 💚
Lines 95.763% (226/236) 👎 -1.081
Conditionals 100.0% (0/0) 💚

kush-elastic
kush-elastic approved these changes Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

agithomas
agithomas approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harnish-elastic
Merge branch 'main' of https://github.com/harnish-elastic/integrations …
5eea373 
…into lens_migration-php_fpm-8.4.0

Conflicts:
	packages/php_fpm/changelog.yml
	packages/php_fpm/manifest.yml
@kush-elastic kush-elastic merged commit ac485f9 into elastic:main Mar 21, 2023
@elasticmachine
Copy link

Package php_fpm - 0.3.0 containing this change is available at https://epr.elastic.co/search?package=php_fpm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kush-elastic kush-elastic kush-elastic approved these changes

@agithomas agithomas agithomas approved these changes

@lalit-satapathy lalit-satapathy Awaiting requested review from lalit-satapathy

Assignees

@harnish-elastic harnish-elastic

Labels
enhancement New feature or request Integration:php_fpm PHP-FPM Team:Service-Integrations Label for the Service Integrations team v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harnish-elastic @elasticmachine @kush-elastic @agithomas