Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][RabbitMQ] Lens migration for visualizations to kibana version 8.0.0 #5536

Merged
merged 3 commits into from
Mar 30, 2023
Merged

[O11y][RabbitMQ] Lens migration for visualizations to kibana version 8.0.0 #5536

merged 3 commits into from
Mar 30, 2023

Conversation

harnish-elastic
Copy link
Contributor

@harnish-elastic harnish-elastic commented Mar 14, 2023 •
edited
Loading

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for RabbitMQ integration package

  • Statistics for RabbitMQ Lens migration:

RabbitMQ Dashboards Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Metrics RabbitMQ] Overview 0 4 4 0
  0 4 4 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.0.0 itself.

Related issues

Note: - Because of RabbitMQ hasn't any dashboard screenshot, please refer this before migrated screenshot for review.

image

@harnish-elastic harnish-elastic mentioned this pull request Mar 14, 2023
Closed
5 tasks
@elasticmachine
Copy link

elasticmachine commented Mar 14, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-21T05:05:40.136+0000

  • Duration: 14 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 14, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 70.0% (14/20) 👎 -30.0
Lines 73.913% (34/46) 👎 -21.198
Conditionals 100.0% (0/0) 💚

@harnish-elastic harnish-elastic marked this pull request as ready for review March 14, 2023 15:38
@harnish-elastic harnish-elastic requested a review from a team as a code owner March 14, 2023 15:38
@kush-elastic kush-elastic added enhancement New feature or request Integration:rabbitmq RabbitMQ Logs and Metrics v8.0.0 Team:Service-Integrations Label for the Service Integrations team labels Mar 14, 2023
agithomas
agithomas approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harnish-elastic
Merge branch 'main' of https://github.com/harnish-elastic/integrations …
8032609 
…into lens_migration-rabbitmq-8.0.0

Conflicts:
	packages/rabbitmq/changelog.yml
	packages/rabbitmq/manifest.yml
kush-elastic
kush-elastic approved these changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic merged commit 541b48e into elastic:main Mar 30, 2023
@elasticmachine
Copy link

Package rabbitmq - 1.7.0 containing this change is available at https://epr.elastic.co/search?package=rabbitmq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kush-elastic kush-elastic kush-elastic approved these changes

@agithomas agithomas agithomas approved these changes

@lalit-satapathy lalit-satapathy Awaiting requested review from lalit-satapathy

Assignees

@harnish-elastic harnish-elastic

Labels
enhancement New feature or request Integration:rabbitmq RabbitMQ Logs and Metrics Team:Service-Integrations Label for the Service Integrations team v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harnish-elastic @elasticmachine @kush-elastic @agithomas