Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][Hadoop] Migrate application dashboard visualizations to lens in kibana 8.3.0 #5607

Merged
merged 7 commits into from
Mar 28, 2023
Merged

[O11y][Hadoop] Migrate application dashboard visualizations to lens in kibana 8.3.0 #5607

merged 7 commits into from
Mar 28, 2023

Conversation

harnish-elastic
Copy link
Contributor

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for Hadoop integration package

  • Statistics for Hadoop Lens migration:

Hadoop dashboards Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Metrics Hadoop] Applications 0 7 7 0
  0 7 7 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in Kibana version 8.3.0.

Related issues

@elasticmachine
Copy link

elasticmachine commented Mar 21, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-28T06:29:14.941+0000

  • Duration: 20 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 39
Skipped 0
Total 39

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 21, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (9/9) 💚
Classes 100.0% (9/9) 💚
Methods 100.0% (47/47) 💚
Lines 99.18% (605/610) 👍 3.957
Conditionals 100.0% (0/0) 💚

This was referenced Mar 21, 2023
Closed
Closed
@harnish-elastic harnish-elastic marked this pull request as ready for review March 21, 2023 11:06
@harnish-elastic harnish-elastic requested a review from a team as a code owner March 21, 2023 11:06
@kush-elastic kush-elastic added enhancement New feature or request Integration:hadoop Hadoop v8.3.0 Team:Service-Integrations Label for the Service Integrations team labels Mar 21, 2023
kush-elastic
kush-elastic approved these changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas
Copy link
Contributor

Curious - why the amount of memory is in (s)? Can you look and make essential adjustments?

@agithomas
Copy link
Contributor

Curious - why the amount of memory is in (s)? Can you look and make essential adjustments?

Similar for the virtual cores as well.

@agithomas
Copy link
Contributor

Why the elapsed time, being a large value, not converted to minutes / hours ? Doesn't lens viz does it automatically?

@harnish-elastic
Copy link
Contributor Author

Why the elapsed time, being a large value, not converted to minutes / hours ? Doesn't lens viz does it automatically?

Yes @agithomas, Lens doesn't have the functionality to convert the value into seconds / minutes / hours / human-readable-format. Please refer the issue: elastic/kibana#153378

Also while migrating the visualization to lens, we kept the same behavior in the lens.

@harnish-elastic
Copy link
Contributor Author

Curious - why the amount of memory is in (s)? Can you look and make essential adjustments?
Similar for the virtual cores as well.

Sure @agithomas, we have raised separate issue for this. #5628
Once these PRs are approved and merged we will raise the PR for this fix as well.

agithomas
agithomas approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harnish-elastic
Merge branch 'main' of https://github.com/harnish-elastic/integrations …
079777d 
…into lens_migration-hadoop-application-8.1.0

Conflicts:
	packages/hadoop/changelog.yml
@harnish-elastic
update package version
076cc28
@kush-elastic kush-elastic merged commit 505dfdd into elastic:main Mar 28, 2023
@elasticmachine
Copy link

Package hadoop - 0.6.0 containing this change is available at https://epr.elastic.co/search?package=hadoop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kush-elastic kush-elastic kush-elastic approved these changes

@agithomas agithomas agithomas approved these changes

@lalit-satapathy lalit-satapathy Awaiting requested review from lalit-satapathy

Assignees

@harnish-elastic harnish-elastic

Labels
enhancement New feature or request Integration:hadoop Hadoop Team:Service-Integrations Label for the Service Integrations team v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harnish-elastic @elasticmachine @agithomas @kush-elastic