-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Elasticsearch] Add dimensions fields for TSDB migration #6623
Changes from 7 commits
cb3db08
e211c80
5a84c3b
76e866a
4209cf2
71d154b
4a75ad0
6b0a747
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,7 @@ | |
fields: | ||
- name: name | ||
type: keyword | ||
dimension: true | ||
- name: task | ||
type: group | ||
fields: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,6 +33,7 @@ | |
fields: | ||
- name: id | ||
type: keyword | ||
dimension: true | ||
description: | | ||
Node ID | ||
- name: name | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
--- | ||
description: "Pipeline for Elasticsearch Ingest Pipeline" | ||
|
||
processors: | ||
- fingerprint: | ||
fields: | ||
- elasticsearch.ingest_pipeline.name | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the
can you please share sample of it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Sorry, I don't understand. A sample of the error? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
sample of the document - part of the document that include this field, there is missing same_event for this data_stream, can't check it there There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here is a sample document
{
"_index": ".ds-metrics-elasticsearch.ingest_pipeline-default-2023.06.23-000001",
"_id": "5p2D54gBH7q8D4JF6839",
"_version": 1,
"_score": 0,
"_source": {
"agent": {
"name": "kind-control-plane",
"id": "a781ce37-a210-49d3-8344-6518fb35d4ac",
"type": "metricbeat",
"ephemeral_id": "55936ecf-0dfb-474d-9031-284992efdf8a",
"version": "8.8.0"
},
"@timestamp": "2023-06-23T09:09:21.280Z",
"elasticsearch": {
"node": {
"roles": [
"data_content",
"data_hot",
"ingest",
"master",
"remote_cluster_client",
"transform"
],
"name": "instance-0000000000",
"id": "J_W-dXFXTxuXnGCwbCb6Iw"
},
"cluster": {
"name": "985f2ca8e1a74327aa2c698275330b90",
"id": "SyM7nU1DRmKd3soposFsXg"
},
"ingest_pipeline": {
"total": {
"count": 428,
"failed": 0,
"time": {
"total": {
"ms": 0
},
"self": {
"ms": 0
}
}
},
"name": "metrics-elasticsearch.stack_monitoring.cluster_stats-1.7.4",
"name_fingerprint": "LX8WOW8tc72gcK7v5HOrWtDf6v4="
}
},
"ecs": {
"version": "8.0.0"
},
"data_stream": {
"namespace": "default",
"type": "metrics",
"dataset": "elasticsearch.ingest_pipeline"
},
"service": {
"address": "https://test-es-3.es.us-central1.gcp.cloud.es.io:9243",
"type": "elasticsearch"
},
"elastic_agent": {
"id": "a781ce37-a210-49d3-8344-6518fb35d4ac",
"version": "8.8.0",
"snapshot": true
},
"host": {
"hostname": "kind-control-plane",
"os": {
"kernel": "5.15.49-linuxkit",
"codename": "focal",
"name": "Ubuntu",
"type": "linux",
"family": "debian",
"version": "20.04.6 LTS (Focal Fossa)",
"platform": "ubuntu"
},
"containerized": false,
"ip": [
"10.244.0.1",
"10.244.0.1",
"10.244.0.1",
"172.18.0.2",
"fc00:f853:ccd:e793::2",
"fe80::42:acff:fe12:2",
"172.25.0.4"
],
"name": "kind-control-plane",
"id": "e12fa0193ee24a5cae5f9665f6e7eb8c",
"mac": [
"02-42-AC-12-00-02",
"02-42-AC-19-00-04",
"22-DE-5A-26-82-AC",
"3A-AE-FC-E1-7E-8C",
"7E-91-38-58-97-2B"
],
"architecture": "x86_64"
},
"metricset": {
"period": 10000,
"name": "ingest_pipeline"
},
"event": {
"duration": 275991722,
"agent_id_status": "verified",
"ingested": "2023-06-23T09:09:22Z",
"module": "elasticsearch",
"dataset": "elasticsearch.ingest_pipeline"
}
},
"fields": {
"elastic_agent.version": [
"8.8.0"
],
"elasticsearch.ingest_pipeline.name_fingerprint": [
"LX8WOW8tc72gcK7v5HOrWtDf6v4="
],
"host.hostname": [
"kind-control-plane"
],
"host.mac": [
"02-42-AC-12-00-02",
"02-42-AC-19-00-04",
"22-DE-5A-26-82-AC",
"3A-AE-FC-E1-7E-8C",
"7E-91-38-58-97-2B"
],
"service.type": [
"elasticsearch"
],
"host.ip": [
"10.244.0.1",
"10.244.0.1",
"10.244.0.1",
"172.18.0.2",
"fc00:f853:ccd:e793::2",
"fe80::42:acff:fe12:2",
"172.25.0.4"
],
"agent.type": [
"metricbeat"
],
"event.module": [
"elasticsearch"
],
"host.os.version": [
"20.04.6 LTS (Focal Fossa)"
],
"elasticsearch.ingest_pipeline.total.time.total.ms": [
0
],
"host.os.kernel": [
"5.15.49-linuxkit"
],
"host.os.name": [
"Ubuntu"
],
"agent.name": [
"kind-control-plane"
],
"host.name": [
"kind-control-plane"
],
"elastic_agent.snapshot": [
true
],
"event.agent_id_status": [
"verified"
],
"host.id": [
"e12fa0193ee24a5cae5f9665f6e7eb8c"
],
"elasticsearch.node.roles": [
"data_content",
"data_hot",
"ingest",
"master",
"remote_cluster_client",
"transform"
],
"elasticsearch.node.id": [
"J_W-dXFXTxuXnGCwbCb6Iw"
],
"elasticsearch.cluster.name": [
"985f2ca8e1a74327aa2c698275330b90"
],
"elasticsearch.ingest_pipeline.total.failed": [
0
],
"host.os.type": [
"linux"
],
"elastic_agent.id": [
"a781ce37-a210-49d3-8344-6518fb35d4ac"
],
"data_stream.namespace": [
"default"
],
"elasticsearch.ingest_pipeline.total.time.self.ms": [
0
],
"metricset.period": [
10000
],
"host.os.codename": [
"focal"
],
"elasticsearch.ingest_pipeline.name": [
"metrics-elasticsearch.stack_monitoring.cluster_stats-1.7.4"
],
"data_stream.type": [
"metrics"
],
"event.duration": [
275991722
],
"elasticsearch.cluster.id": [
"SyM7nU1DRmKd3soposFsXg"
],
"host.architecture": [
"x86_64"
],
"metricset.name": [
"ingest_pipeline"
],
"event.ingested": [
"2023-06-23T09:09:22.000Z"
],
"@timestamp": [
"2023-06-23T09:09:21.280Z"
],
"elasticsearch.node.name": [
"instance-0000000000"
],
"agent.id": [
"a781ce37-a210-49d3-8344-6518fb35d4ac"
],
"elasticsearch.ingest_pipeline.total.count": [
428
],
"ecs.version": [
"8.0.0"
],
"host.os.platform": [
"ubuntu"
],
"host.containerized": [
false
],
"service.address": [
"https://test-es-3.es.us-central1.gcp.cloud.es.io:9243"
],
"data_stream.dataset": [
"elasticsearch.ingest_pipeline"
],
"agent.ephemeral_id": [
"55936ecf-0dfb-474d-9031-284992efdf8a"
],
"agent.version": [
"8.8.0"
],
"host.os.family": [
"debian"
],
"event.dataset": [
"elasticsearch.ingest_pipeline"
]
}
} There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. looking at this sample, does adding a dimension on There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, the |
||
target_field: elasticsearch.ingest_pipeline.name_fingerprint | ||
ignore_missing: true | ||
on_failure: | ||
- set: | ||
field: 'error.message' | ||
value: '{{ _ingest.on_failure_message }}' |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ | |
fields: | ||
- name: id | ||
type: keyword | ||
dimension: true | ||
description: | | ||
Unique ml job id. | ||
- name: state | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,6 +37,7 @@ | |
Node ID | ||
- name: name | ||
type: keyword | ||
dimension: true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. wouldn't node.id be a better candidate? it could be not unique for multiple clusters There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Each cluster only has one There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For the integration to work you need to give the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
why? If I set
but there can be the same example: I have 2 different instance: es-test and es-test2 in the same gcp account (it is just for the test, more realistic: have instance with the same name in different accounts/in different cloud providers, just for the test I've changes the hostname of es-test2 to es-test):
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am a bit confused. To install the integration in some policy you need to set the This way, the
So install two different agents? The
We always have value for I tested it it by adding to the policy:
I didn't get any overlap. |
||
description: | | ||
Node name. | ||
- name: master | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -316,6 +316,7 @@ | |
Node ID | ||
- name: name | ||
type: keyword | ||
dimension: true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the same as for |
||
description: | | ||
Node name. | ||
- name: master | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wondering if cluster.id will not be a better candidate for the dimension?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not migrate this one, it is still pending (description).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but you are planning to add dimension fields for this data_streams that are blocked by mentioned in description issues, in this PR? or you plan to move those data_streams to another PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They will be moved to another PR. I will remove this dimension, but I will leave the
ecs
ones, just to not cause confusion then.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the one for cluster stats (as I believe it is also not necessary). I am leaving the
enrich
dimensions though, even if it is not migrated - I will validate it again when the issue is resolved.