-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Airflow] Remove metric_type mapping for 'airflow.scheduler.heartbeat' field and adjust the dashboard to visualize this #7554
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
@lalit-satapathy / @ritalwar , I want to propose a third option - not to mention either gauge / counter following the conflicted behaviour we noticed and what is documented. Yes, this would lead to not able to benefit TSDB advantages. We can create a backlog item for metric_type mapping of this field. As we get more clarity, the change to map either to |
The advantage with the above approach is that the change (and thus the readme) don't contradict the official documentation of couchdb. |
I think we can go with this to avoid any conflicts and keep this issue open. However, let's keep this PR to stick with the 'last_value' as the aggregator function for this visualisation, as discussed. We'll put the metric_type mapping on hold for now. @lalit-satapathy , WDYT? |
Following our discussion, I've removed the metric_type mapping for the 'scheduler.heartbeat' field and made the necessary updates to the dashboard, utilizing 'last_value' for visualizing this field's data. We can maintain the related issue as open to determine the appropriate metric_type mapping without conflicting with the documentation. |
airflow.scheduler.heartbeat
to gauge.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Package airflow - 0.3.1 containing this change is available at https://epr.elastic.co/search?package=airflow |
What does this PR do?
This PR modifies the metric_type of
airflow.scheduler.heartbeat
from counter to gauge. Despite the field being labeled as a counter in the airflow documentation, the behavior of the values—consistently 1 or 2—suggests it aligns better with the characteristics of a gauge metric.Additionally, dashboard is modified to accurately represent this data, with the aggregator function updated to use last_value.
Checklist
changelog.yml
file.Related issues
scheduler.heartbeat
field in the context of TSDB. #7504Screenshots