RESET ME

x-pack/plugins/enterprise_search/public/applications/app_search/components/engine_overview/components/empty_state.tsx

@@ -8,6 +8,7 @@ import React, { useContext } from 'react';
 import { EuiPageContent, EuiEmptyPrompt, EuiButton } from '@elastic/eui';
 import { FormattedMessage } from '@kbn/i18n/react';
 
+import { FlashMessages } from '../../../../shared/flash_messages';
 import { sendTelemetry } from '../../../../shared/telemetry';
 import { SetAppSearchChrome as SetPageChrome } from '../../../../shared/kibana_chrome';
 import { KibanaContext, IKibanaContext } from '../../../../index';
@@ -40,6 +41,7 @@ export const EmptyState: React.FC = () => {
       <SetPageChrome isRoot />
       <EngineOverviewHeader />
       <EuiPageContent className="emptyState">
+        <FlashMessages />
         <EuiEmptyPrompt
           className="emptyState__prompt"
           iconType="eyeClosed"

x-pack/plugins/enterprise_search/public/applications/app_search/components/engine_overview/components/loading_state.tsx

@@ -7,6 +7,7 @@
 import React from 'react';
 import { EuiPageContent, EuiSpacer, EuiLoadingContent } from '@elastic/eui';
 
+import { FlashMessages } from '../../../../shared/flash_messages';
 import { SetAppSearchChrome as SetPageChrome } from '../../../../shared/kibana_chrome';
 import { EngineOverviewHeader } from './header';
 
@@ -16,6 +17,7 @@ export const LoadingState: React.FC = () => {
       <SetPageChrome isRoot />
       <EngineOverviewHeader />
       <EuiPageContent paddingSize="l">
+        <FlashMessages />
         <EuiLoadingContent lines={5} />
         <EuiSpacer size="xxl" />
         <EuiLoadingContent lines={4} />

x-pack/plugins/enterprise_search/public/applications/app_search/components/engine_overview/engine_overview.tsx

@@ -16,7 +16,7 @@ import { FormattedMessage } from '@kbn/i18n/react';
 
 import { SetAppSearchChrome as SetPageChrome } from '../../../shared/kibana_chrome';
 import { SendAppSearchTelemetry as SendTelemetry } from '../../../shared/telemetry';
-import { FlashMessages } from '../../../shared/flash_messages';
+import { FlashMessages, handleAPIError } from '../../../shared/flash_messages';
 import { LicenseContext, ILicenseContext, hasPlatinumLicense } from '../../../shared/licensing';
 import { KibanaContext, IKibanaContext } from '../../../index';
 
@@ -50,9 +50,14 @@ export const EngineOverview: React.FC = () => {
   const [metaEnginesTotal, setMetaEnginesTotal] = useState(0);
 
   const getEnginesData = async ({ type, pageIndex }: IGetEnginesParams) => {
-    return await http.get('/api/app_search/engines', {
-      query: { type, pageIndex },
-    });
+    try {
+      return await http.get('/api/app_search/engines', {
+        query: { type, pageIndex },
+      });
+    } catch (e) {
+      setIsLoading(false);
+      handleAPIError(e);
+    }
   };
   const setEnginesData = async (params: IGetEnginesParams, callbacks: ISetEnginesCallbacks) => {
     const response = await getEnginesData(params);

x-pack/plugins/enterprise_search/public/applications/shared/flash_messages/index.ts

@@ -12,3 +12,4 @@ export {
   IFlashMessagesActions,
 } from './flash_messages_logic';
 export { FlashMessagesProvider } from './flash_messages_provider';
+export { handleAPIError } from './handle_api_errors';

x-pack/plugins/enterprise_search/public/applications/workplace_search/views/overview/overview.tsx

@@ -13,6 +13,7 @@ import { useActions, useValues } from 'kea';
 
 import { SetWorkplaceSearchChrome as SetPageChrome } from '../../../shared/kibana_chrome';
 import { SendWorkplaceSearchTelemetry as SendTelemetry } from '../../../shared/telemetry';
+import { FlashMessages } from '../../../shared/flash_messages';
 
 import { OverviewLogic } from './overview_logic';
 
@@ -58,7 +59,7 @@ export const Overview: React.FC = () => {
     initializeOverview();
   }, [initializeOverview]);
 
-  if (dataLoading) return <Loading />;
+  // if (dataLoading) return <Loading />;
 
   const hideOnboarding = hasUsers && hasOrgSources && isOldAccount && orgName !== defaultOrgName;
 
@@ -76,6 +77,7 @@ export const Overview: React.FC = () => {
           description={headerDescription}
           action={<ProductButton />}
         />
+        <FlashMessages />
         {!hideOnboarding && <OnboardingSteps />}
         <EuiSpacer size="xl" />
         <OrganizationStats />

x-pack/plugins/enterprise_search/public/applications/workplace_search/views/overview/overview_logic.ts

@@ -6,6 +6,7 @@
 
 import { kea, MakeLogicType } from 'kea';
 import { HttpLogic } from '../../../shared/http';
+import { handleAPIError } from '../../../shared/flash_messages';
 
 import { IAccount, IOrganization } from '../../types';
 
@@ -129,8 +130,12 @@ export const OverviewLogic = kea<MakeLogicType<IOverviewValues, IOverviewActions
   },
   listeners: ({ actions }) => ({
     initializeOverview: async () => {
-      const response = await HttpLogic.values.http.get('/api/workplace_search/overview');
-      actions.setServerData(response);
+      try {
+        const response = await HttpLogic.values.http.get('/api/workplace_search/overview');
+        actions.setServerData(response);
+      } catch (e) {
+        handleAPIError(e);
+      }
     },
   }),
 });

x-pack/plugins/enterprise_search/server/routes/app_search/engines.ts

@@ -32,7 +32,10 @@ export function registerEnginesRoute({
       const { type, pageIndex } = request.query;
 
       return enterpriseSearchRequestHandler.createRequest({
-        path: '/as/engines/collection',
+        // path: '/as/engines/collection',
+        // path: '/as/engines/wtf/details', // 404 w no message
+        path: '/as/engines/test/curations/cur-doesntexist.json', // 404 w error message
+        // path: '/as/engines/test/synonyms/collection', // 500
         params: {
           type,
           'page[current]': pageIndex,

x-pack/plugins/enterprise_search/server/routes/workplace_search/overview.ts

@@ -16,7 +16,7 @@ export function registerWSOverviewRoute({
       validate: false,
     },
     enterpriseSearchRequestHandler.createRequest({
-      path: '/ws/org',
+      path: '/as/engines/test/curations/cur-doesntexist.json',
       hasValidData: (body: { accountsCount: number }) => typeof body?.accountsCount === 'number',
     })
   );