Fix all editor frame tests

elastic · Mar 6, 2020 · 0e22ae5 · 0e22ae5
1 parent 9178b13
commit 0e22ae5
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 13 deletions.
diff --git a/x-pack/legacy/plugins/lens/public/editor_frame_service/editor_frame/config_panel_wrapper.tsx b/x-pack/legacy/plugins/lens/public/editor_frame_service/editor_frame/config_panel_wrapper.tsx
@@ -98,7 +98,7 @@ function LayerPanels(
         type: 'UPDATE_VISUALIZATION_STATE',
         visualizationId: activeVisualization.id,
         newState,
-        clearStagedPreview: true,
+        clearStagedPreview: false,
       });
     },
     [props.dispatch, activeVisualization]
@@ -109,7 +109,7 @@ function LayerPanels(
         type: 'UPDATE_DATASOURCE_STATE',
         updater: () => newState,
         datasourceId,
-        clearStagedPreview: true,
+        clearStagedPreview: false,
       });
     },
     [props.dispatch]
@@ -204,6 +204,9 @@ function LayerPanel(
   const dragDropContext = useContext(DragContext);
   const { framePublicAPI, layerId, activeVisualization, isOnlyLayer, onRemove } = props;
   const datasourcePublicAPI = framePublicAPI.datasourceLayers[layerId];
+  if (!datasourcePublicAPI) {
+    return <></>;
+  }
   const layerVisualizationConfigProps = {
     layerId,
     dragDropContext,

diff --git a/x-pack/legacy/plugins/lens/public/editor_frame_service/editor_frame/editor_frame.test.tsx b/x-pack/legacy/plugins/lens/public/editor_frame_service/editor_frame/editor_frame.test.tsx
@@ -635,14 +635,13 @@ describe('editor_frame', () => {
 
       const updatedState = {};
       const setVisualizationState = (mockVisualization.getLayerOptions as jest.Mock).mock
-        .calls[0][1].setState;
+        .calls[0][0].setState;
       act(() => {
         setVisualizationState(updatedState);
       });
 
       expect(mockVisualization.getLayerOptions).toHaveBeenCalledTimes(2);
       expect(mockVisualization.getLayerOptions).toHaveBeenLastCalledWith(
-        // expect.any(Element),
         expect.objectContaining({
           state: updatedState,
         })
@@ -722,7 +721,6 @@ describe('editor_frame', () => {
 
       expect(mockVisualization.getLayerOptions).toHaveBeenCalledTimes(2);
       expect(mockVisualization.getLayerOptions).toHaveBeenLastCalledWith(
-        // expect.any(Element),
         expect.objectContaining({
           frame: expect.objectContaining({
             datasourceLayers: {
@@ -738,6 +736,7 @@ describe('editor_frame', () => {
     it('should pass the datasource api for each layer to the visualization', async () => {
       mockDatasource.getLayers.mockReturnValue(['first']);
       mockDatasource2.getLayers.mockReturnValue(['second', 'third']);
+      mockVisualization.getLayerIds.mockReturnValue(['first', 'second', 'third']);
 
       mount(
         <EditorFrame
@@ -776,7 +775,8 @@ describe('editor_frame', () => {
 
       expect(mockVisualization.getLayerOptions).toHaveBeenCalled();
 
-      const datasourceLayers = mockVisualization.initialize.mock.calls[0][0].datasourceLayers;
+      const datasourceLayers =
+        mockVisualization.getLayerOptions.mock.calls[0][0].frame.datasourceLayers;
       expect(datasourceLayers.first).toBe(mockDatasource.publicAPIMock);
       expect(datasourceLayers.second).toBe(mockDatasource2.publicAPIMock);
       expect(datasourceLayers.third).toBe(mockDatasource2.publicAPIMock);
@@ -1039,7 +1039,6 @@ describe('editor_frame', () => {
       expect(mockVisualization2.getSuggestions).toHaveBeenCalled();
       expect(mockVisualization2.initialize).toHaveBeenCalledWith(expect.anything(), initialState);
       expect(mockVisualization2.getLayerOptions).toHaveBeenCalledWith(
-        // expect.any(Element),
         expect.objectContaining({ state: { initial: true } })
       );
     });
@@ -1057,7 +1056,6 @@ describe('editor_frame', () => {
         })
       );
       expect(mockVisualization2.getLayerOptions).toHaveBeenCalledWith(
-        expect.any(Element),
         expect.objectContaining({ state: { initial: true } })
       );
     });
@@ -1254,7 +1252,6 @@ describe('editor_frame', () => {
 
       expect(mockVisualization.getLayerOptions).toHaveBeenCalledTimes(1);
       expect(mockVisualization.getLayerOptions).toHaveBeenCalledWith(
-        // expect.any(Element),
         expect.objectContaining({
           state: suggestionVisState,
         })
@@ -1319,7 +1316,6 @@ describe('editor_frame', () => {
       });
 
       expect(mockVisualization.getLayerOptions).toHaveBeenCalledWith(
-        // expect.any(Element),
         expect.objectContaining({
           state: suggestionVisState,
         })
@@ -1393,7 +1389,6 @@ describe('editor_frame', () => {
       });
 
       expect(mockVisualization2.getLayerOptions).toHaveBeenCalledWith(
-        expect.any(Element),
         expect.objectContaining({
           state: suggestionVisState,
         })
@@ -1489,7 +1484,6 @@ describe('editor_frame', () => {
       });
 
       expect(mockVisualization3.getLayerOptions).toHaveBeenCalledWith(
-        // expect.any(Element),
         expect.objectContaining({
           state: suggestionVisState,
         })

diff --git a/x-pack/legacy/plugins/lens/public/types.ts b/x-pack/legacy/plugins/lens/public/types.ts
@@ -257,7 +257,6 @@ export interface LensMultiTable {
 
 export interface VisualizationLayerConfigProps<T = unknown> {
   layerId: string;
-  // dragDropContext: DragContextState;
   frame: FramePublicAPI;
   state: T;
   setState: (newState: T) => void;