more cleanup

elastic · Jun 13, 2019 · 11c5da3 · 11c5da3
1 parent aa6fe73
commit 11c5da3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/legacy/ui/public/vis/vis_types/vislib_vis_legend.js b/src/legacy/ui/public/vis/vis_types/vislib_vis_legend.js
@@ -22,15 +22,14 @@ import { i18n } from '@kbn/i18n';
 import html from './vislib_vis_legend.html';
 import { Data } from '../../vislib/lib/data';
 import { uiModules } from '../../modules';
-import { VisFiltersProvider } from '../vis_filters';
+import { createFiltersFromEvent } from '../vis_filters';
 import { htmlIdGenerator, keyCodes } from '@elastic/eui';
 import { getTableAggs } from '../../visualize/loader/pipeline_helpers/utilities';
 
 export const CUSTOM_LEGEND_VIS_TYPES = ['heatmap', 'gauge'];
 
 uiModules.get('kibana')
-  .directive('vislibLegend', function (Private, $timeout) {
-    const visFilters = Private(VisFiltersProvider);
+  .directive('vislibLegend', function ($timeout) {
 
     return {
       restrict: 'E',
@@ -97,7 +96,7 @@ uiModules.get('kibana')
           if (CUSTOM_LEGEND_VIS_TYPES.includes($scope.vis.vislibVis.visConfigArgs.type)) {
             return false;
           }
-          const filters = visFilters.filter({ aggConfigs: $scope.tableAggs, data: legendData.values }, { simulate: true });
+          const filters = createFiltersFromEvent({ aggConfigs: $scope.tableAggs, data: legendData.values });
           return filters.length;
         };
 

diff --git a/src/legacy/ui/public/visualize/loader/embedded_visualize_handler.ts b/src/legacy/ui/public/visualize/loader/embedded_visualize_handler.ts
@@ -33,7 +33,7 @@ import { RenderCompleteHelper } from '../../render_complete';
 import { AppState } from '../../state_management/app_state';
 import { timefilter } from '../../timefilter';
 import { RequestHandlerParams, Vis } from '../../vis';
-// @ts-ignore
+// @ts-ignore untyped dependency
 import { VisFiltersProvider } from '../../vis/vis_filters';
 import { PipelineDataLoader } from './pipeline_data_loader';
 import { visualizationLoader } from './visualization_loader';