Cleanup and adding some types

elastic · May 6, 2020 · 18c82f2 · 18c82f2
1 parent 23b4e68
commit 18c82f2
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/x-pack/plugins/canvas/public/application.tsx b/x-pack/plugins/canvas/public/application.tsx
@@ -10,8 +10,9 @@ import ReactDOM from 'react-dom';
 import { I18nProvider } from '@kbn/i18n/react';
 import { i18n } from '@kbn/i18n';
 import { Provider } from 'react-redux';
+import { Observable } from 'rxjs';
 
-import { AppMountParameters, CoreStart, CoreSetup } from 'kibana/public';
+import { AppMountParameters, CoreStart, CoreSetup, AppUpdater } from 'kibana/public';
 
 import { CanvasStartDeps, CanvasSetupDeps } from './plugin';
 // @ts-ignore Untyped local
@@ -89,7 +90,7 @@ export const initializeCanvas = async (
   setupPlugins: CanvasSetupDeps,
   startPlugins: CanvasStartDeps,
   registries: SetupRegistries,
-  navUpdater: any
+  navUpdater: Observable<AppUpdater>
 ) => {
   startServices(coreSetup, coreStart, setupPlugins, startPlugins, navUpdater);
 

diff --git a/x-pack/plugins/canvas/public/services/index.ts b/x-pack/plugins/canvas/public/services/index.ts
@@ -4,7 +4,8 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { CoreSetup, CoreStart } from '../../../../../src/core/public';
+import { Observable } from 'rxjs';
+import { CoreSetup, CoreStart, AppUpdater } from '../../../../../src/core/public';
 import { CanvasSetupDeps, CanvasStartDeps } from '../plugin';
 import { notifyServiceFactory } from './notify';
 import { platformServiceFactory } from './platform';
@@ -15,7 +16,7 @@ export type CanvasServiceFactory<Service> = (
   coreStart: CoreStart,
   canvasSetupPlugins: CanvasSetupDeps,
   canvasStartPlugins: CanvasStartDeps,
-  appUpdater: any
+  appUpdater: Observable<AppUpdater>
 ) => Service;
 
 class CanvasServiceProvider<Service> {
@@ -31,7 +32,7 @@ class CanvasServiceProvider<Service> {
     coreStart: CoreStart,
     canvasSetupPlugins: CanvasSetupDeps,
     canvasStartPlugins: CanvasStartDeps,
-    appUpdater: any
+    appUpdater: Observable<AppUpdater>
   ) {
     this.service = this.factory(
       coreSetup,

diff --git a/x-pack/plugins/canvas/public/services/nav_link.ts b/x-pack/plugins/canvas/public/services/nav_link.ts
@@ -5,7 +5,6 @@
  */
 
 import { CanvasServiceFactory } from '.';
-import { CoreStart, CoreSetup, CanvasSetupDeps, CanvasStartDeps } from '../plugin';
 import { SESSIONSTORAGE_LASTPATH } from '../../common/lib/constants';
 
 interface NavLinkService {