tslint

elastic · Jun 2, 2023 · 1a29b11 · 1a29b11
1 parent 4462e57
commit 1a29b11
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/src/plugins/data/common/search/aggs/buckets/significant_terms.ts b/src/plugins/data/common/search/aggs/buckets/significant_terms.ts
@@ -23,8 +23,8 @@ export interface AggParamsSignificantTerms extends BaseAggParams {
   field: string;
   size?: number;
   shardSize?: number;
-  exclude?: string;
-  include?: string;
+  exclude?: string | string[];
+  include?: string | string[];
 }
 
 export const getSignificantTermsBucketAgg = () =>

diff --git a/src/plugins/data/common/search/aggs/buckets/significant_terms_fn.ts b/src/plugins/data/common/search/aggs/buckets/significant_terms_fn.ts
@@ -75,12 +75,14 @@ export const aggSignificantTerms = (): FunctionDefinition => ({
       help: i18n.translate('data.search.aggs.buckets.significantTerms.exclude.help', {
         defaultMessage: 'Specific bucket values to exclude from results',
       }),
+      multi: true,
     },
     include: {
       types: ['string'],
       help: i18n.translate('data.search.aggs.buckets.significantTerms.include.help', {
         defaultMessage: 'Specific bucket values to include in results',
       }),
+      multi: true,
     },
     json: {
       types: ['string'],

diff --git a/x-pack/plugins/lens/public/datasources/form_based/operations/definitions/terms/index.tsx b/x-pack/plugins/lens/public/datasources/form_based/operations/definitions/terms/index.tsx
@@ -281,6 +281,8 @@ export const termsOperation: OperationDefinition<
       ? Math.max(1000, column.params.size * 1.5 + 10)
       : undefined;
 
+    console.log(column.params.include);
+
     if (column.params?.orderBy.type === 'significant') {
       return buildExpressionFunction<AggFunctionsMapping['aggSignificantTerms']>(
         'aggSignificantTerms',
@@ -291,8 +293,8 @@ export const termsOperation: OperationDefinition<
           field: column.sourceField,
           size: column.params.size,
           shardSize,
-          ...(column.params.include?.length && { include: column.params.include }),
-          ...(column.params.exclude?.length && { exclude: column.params.exclude }),
+          ...(column.params.include?.length && { include: column.params.include as string[] }),
+          ...(column.params.exclude?.length && { exclude: column.params.exclude as string[] }),
         }
       ).toAst();
     }
@@ -1092,8 +1094,7 @@ The top values of a specified field ranked by the chosen metric.
                 data-test-subj="indexPattern-accuracy-mode"
                 checked={Boolean(
                   currentColumn.params.accuracyMode &&
-                    (currentColumn.params.orderBy.type !== 'rare' ||
-                      currentColumn.params.orderBy.type === 'significant')
+                    currentColumn.params.orderBy.type !== 'rare'
                 )}
                 onChange={(e: EuiSwitchEvent) =>
                   paramEditorUpdater(