Add tests

elastic · May 4, 2022 · 1cdb5c0 · 1cdb5c0
1 parent 2fc8a44
commit 1cdb5c0
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/src/plugins/chart_expressions/expression_xy/common/expression_functions/validate.ts b/src/plugins/chart_expressions/expression_xy/common/expression_functions/validate.ts
@@ -40,7 +40,8 @@ const errors = {
     }),
   isInvalidIntervalError: () =>
     i18n.translate('expressionXY.reusable.function.xyVis.errors.isInvalidIntervalError', {
-      defaultMessage: 'Provided x-axis interval is invalid',
+      defaultMessage:
+        'Provided x-axis interval is invalid. The interval should includes quantity and unit name like 1d, 24h, 1w.',
     }),
 };
 

diff --git a/src/plugins/chart_expressions/expression_xy/common/i18n/index.tsx b/src/plugins/chart_expressions/expression_xy/common/i18n/index.tsx
@@ -114,7 +114,7 @@ export const strings = {
       defaultMessage: 'Specifies the aria label of the xy chart',
     }),
   getXAxisIntervalHelp: () =>
-    i18n.translate('expressionXY.xyVis.ariaLabel.help', {
+    i18n.translate('expressionXY.xyVis.xAxisInterval.help', {
       defaultMessage: 'Specifies the interval for x-axis',
     }),
   getDataLayerFnHelp: () =>

diff --git a/src/plugins/chart_expressions/expression_xy/public/helpers/interval.test.ts b/src/plugins/chart_expressions/expression_xy/public/helpers/interval.test.ts
@@ -86,4 +86,18 @@ describe('calculateMinInterval', () => {
     const result = await calculateMinInterval(xyProps);
     expect(result).toEqual(undefined);
   });
+
+  it('should return specified interval if user provided it as `xAxisInterval`', async () => {
+    layer.table.columns[2].meta.source = 'esaggs';
+    layer.table.columns[2].meta.sourceParams = {
+      type: 'date_histogram',
+      params: {
+        used_interval: '5m',
+      },
+    };
+    xyProps.args.layers[0] = layer;
+    xyProps.args.xAxisInterval = '1h';
+    const result = await calculateMinInterval(xyProps);
+    expect(result).toEqual(60 * 60 * 1000);
+  });
 });