Skip to content

Commit

Permalink
Adding to Contributing doc about where to put the SASS import
Browse files Browse the repository at this point in the history
  • Loading branch information
cchaos committed Jul 13, 2020
1 parent b5e27f2 commit 1eff888
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@ We are still to develop a proper process to accept any contributed translations.

### Styling with SASS

When writing a new component, create a sibling SASS file of the same name and import directly into the JS/TS component file. Doing so ensures the styles are never separated or lost on import and allows for better modularization (smaller individual plugin asset footprint).
When writing a new component, create a sibling SASS file of the same name and import directly into the **top** of the JS/TS component file. Doing so ensures the styles are never separated or lost on import and allows for better modularization (smaller individual plugin asset footprint).

All SASS (.scss) files will automatically build with the [EUI](https://elastic.github.io/eui/#/guidelines/sass) & Kibana invisibles (SASS variables, mixins, functions) from the [`globals_[theme].scss` file](src/legacy/ui/public/styles/_globals_v7light.scss).

Expand Down

0 comments on commit 1eff888

Please sign in to comment.