🐛 Address both convertion issue at the source

elastic · May 28, 2021 · 266dd99 · 266dd99
1 parent 13fb8cb
commit 266dd99
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/x-pack/plugins/lens/public/datatable_visualization/components/dimension_editor.tsx b/x-pack/plugins/lens/public/datatable_visualization/components/dimension_editor.tsx
@@ -81,10 +81,7 @@ export function TableDimensionEditor(
       []
     : [accessor];
   const minMaxByColumnId = findMinMaxByColumnId(columnsToCheck, currentData);
-  const currentMinMax = minMaxByColumnId[accessor] || {
-    min: defaultPaletteParams.rangeMin,
-    max: defaultPaletteParams.rangeMax,
-  };
+  const currentMinMax = minMaxByColumnId[accessor];
 
   const activePalette = column?.palette || {
     type: 'palette',

diff --git a/x-pack/plugins/lens/public/datatable_visualization/components/shared_utils.tsx b/x-pack/plugins/lens/public/datatable_visualization/components/shared_utils.tsx
@@ -9,7 +9,7 @@ import { Datatable } from 'src/plugins/expressions';
 import { getOriginalId } from '../transpose_helpers';
 
 export const findMinMaxByColumnId = (columnIds: string[], table: Datatable | undefined) => {
-  const minMax: Record<string, { min: number; max: number }> = {};
+  const minMax: Record<string, { min: number; max: number; fallback?: boolean }> = {};
 
   if (table != null) {
     for (const columnId of columnIds) {
@@ -26,6 +26,10 @@ export const findMinMaxByColumnId = (columnIds: string[], table: Datatable | und
           }
         }
       });
+      // what happens when there's no data in the table? Fallback to a percent range
+      if (minMax[originalId].max === -Infinity) {
+        minMax[originalId] = { max: 100, min: 0, fallback: true };
+      }
     }
   }
   return minMax;