Skip to content

Commit

Permalink
Fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
chrisronline committed Jul 16, 2020
1 parent f3fb866 commit 310c801
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
2 changes: 1 addition & 1 deletion x-pack/plugins/monitoring/public/alerts/callout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const TYPES = [
severity: AlertSeverity.Danger,
color: 'danger',
label: i18n.translate('xpack.monitoring.alerts.callout.dangerLabel', {
defaultMessage: 'DAnger alert(s)',
defaultMessage: 'Danger alert(s)',
}),
},
];
Expand Down
15 changes: 15 additions & 0 deletions x-pack/plugins/monitoring/server/alerts/nodes_changed_alert.ts
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,21 @@ export class NodesChangedAlert extends BaseAlert {
};
}

if (
Object.values(states.added).length === 0 &&
Object.values(states.removed).length === 0 &&
Object.values(states.restarted).length === 0
) {
return {
text: i18n.translate(
'xpack.monitoring.alerts.nodesChanged.ui.nothingDetectedFiringMessage',
{
defaultMessage: `Elasticsearch nodes have changed`,
}
),
};
}

const addedText =
Object.values(states.added).length > 0
? i18n.translate('xpack.monitoring.alerts.nodesChanged.ui.addedFiringMessage', {
Expand Down

0 comments on commit 310c801

Please sign in to comment.