update hook being used to update privileges, one performs better than…

… the other
elastic · Mar 8, 2022 · 360cf66 · 360cf66
1 parent 4e3b91d
commit 360cf66
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 12 deletions.
diff --git a/x-pack/plugins/security_solution/public/detections/pages/alerts/index.tsx b/x-pack/plugins/security_solution/public/detections/pages/alerts/index.tsx
@@ -8,9 +8,9 @@
 import React from 'react';
 import { Route, Switch } from 'react-router-dom';
 
-import * as i18n from './translations';
 import { ALERTS_PATH, SecurityPageName } from '../../../../common/constants';
 import { NotFoundPage } from '../../../app/404';
+import * as i18n from './translations';
 import { TrackApplicationView } from '../../../../../../../src/plugins/usage_collection/public';
 import { DetectionEnginePage } from '../../pages/detection_engine/detection_engine';
 import { SpyRoute } from '../../../common/utils/route/spy_routes';

diff --git a/x-pack/plugins/security_solution/public/use_readonly_header.ts b/x-pack/plugins/security_solution/public/use_readonly_header.ts
@@ -5,38 +5,33 @@
  * 2.0.
  */
 
-import { useCallback, useEffect } from 'react';
+import { useEffect } from 'react';
 
 import * as i18n from './translations';
 import { useKibana } from './common/lib/kibana';
-import { useUserInfo } from './detections/components/user_info';
+import { useAlertsPrivileges } from './detections/containers/detection_engine/alerts/use_alerts_privileges';
 
 /**
  * This component places a read-only icon badge in the header
  * if user only has read *Kibana* privileges, not individual data index
  * privileges
  */
 export function useReadonlyHeader(tooltip: string) {
-  const { canUserREAD, canUserCRUD } = useUserInfo();
+  const { hasKibanaREAD, hasKibanaCRUD } = useAlertsPrivileges();
   const chrome = useKibana().services.chrome;
 
-  // if the user is read only then display the glasses badge in the global navigation header
-  const setBadge = useCallback(() => {
-    if (canUserREAD && !canUserCRUD) {
+  useEffect(() => {
+    if (hasKibanaREAD && !hasKibanaCRUD) {
       chrome.setBadge({
         text: i18n.READ_ONLY_BADGE_TEXT,
         tooltip,
         iconType: 'glasses',
       });
     }
-  }, [chrome, canUserREAD, canUserCRUD, tooltip]);
-
-  useEffect(() => {
-    setBadge();
 
     // remove the icon after the component unmounts
     return () => {
       chrome.setBadge();
     };
-  }, [setBadge, chrome]);
+  }, [chrome, hasKibanaREAD, hasKibanaCRUD, tooltip]);
 }