Change implementation on TSVB functional when testing the indexPatter…

…n switch (#78754) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
elastic · Oct 1, 2020 · 36814aa · 36814aa
1 parent 8f89ef5
commit 36814aa
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/test/functional/apps/visualize/_tsvb_chart.ts b/test/functional/apps/visualize/_tsvb_chart.ts
@@ -135,11 +135,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         await PageObjects.visualBuilder.clickPanelOptions('metric');
         const fromTime = 'Oct 22, 2018 @ 00:00:00.000';
         const toTime = 'Oct 28, 2018 @ 23:59:59.999';
+        await PageObjects.timePicker.setAbsoluteRange(fromTime, toTime);
         // Sometimes popovers take some time to appear in Firefox (#71979)
         await retry.tryForTime(20000, async () => {
-          await PageObjects.timePicker.setAbsoluteRange(fromTime, toTime);
           await PageObjects.visualBuilder.setIndexPatternValue('kibana_sample_data_flights');
-          await PageObjects.common.sleep(3000);
+          await PageObjects.visualBuilder.waitForIndexPatternTimeFieldOptionsLoaded();
           await PageObjects.visualBuilder.selectIndexPatternTimeField('timestamp');
         });
         const newValue = await PageObjects.visualBuilder.getMetricValue();

diff --git a/test/functional/page_objects/visual_builder_page.ts b/test/functional/page_objects/visual_builder_page.ts
@@ -453,6 +453,14 @@ export function VisualBuilderPageProvider({ getService, getPageObjects }: FtrPro
       await PageObjects.header.waitUntilLoadingHasFinished();
     }
 
+    public async waitForIndexPatternTimeFieldOptionsLoaded() {
+      await retry.waitFor('combobox options loaded', async () => {
+        const options = await comboBox.getOptions('metricsIndexPatternFieldsSelect');
+        log.debug(`-- optionsCount=${options.length}`);
+        return options.length > 0;
+      });
+    }
+
     public async selectIndexPatternTimeField(timeField: string) {
       await retry.try(async () => {
         await comboBox.clearInputField('metricsIndexPatternFieldsSelect');

diff --git a/test/functional/services/combo_box.ts b/test/functional/services/combo_box.ts
@@ -58,6 +58,17 @@ export function ComboBoxProvider({ getService, getPageObjects }: FtrProviderCont
       return isMouseClick ? await element.clickMouseButton() : await element._webElement.click();
     }
 
+    /**
+     * Finds combobox element options
+     *
+     * @param comboBoxSelector data-test-subj selector
+     */
+    public async getOptions(comboBoxSelector: string) {
+      const comboBoxElement = await testSubjects.find(comboBoxSelector);
+      await this.openOptionsList(comboBoxElement);
+      return await find.allByCssSelector('.euiFilterSelectItem', WAIT_FOR_EXISTS_TIME);
+    }
+
     /**
      * Sets value for specified combobox element
      *