Please code review

elastic · May 16, 2022 · 3dd4fba · 3dd4fba
1 parent 69c53a5
commit 3dd4fba
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/x-pack/plugins/security_solution/public/common/links/links.ts b/x-pack/plugins/security_solution/public/common/links/links.ts
@@ -204,3 +204,7 @@ export const useAppNavLinks = (): NavLinkItem[] => {
 
   return getNavLinkItems({ enableExperimental, license, capabilities });
 };
+
+export const useAppNavLink = (pageName: SecurityPageName): NavLinkItem | undefined => {
+  return useAppNavLinks().find(({ id }) => id === pageName);
+};
diff --git a/x-pack/plugins/security_solution/public/landing_pages/pages/dashboards.tsx b/x-pack/plugins/security_solution/public/landing_pages/pages/dashboards.tsx
@@ -11,12 +11,10 @@ import { SecuritySolutionPageWrapper } from '../../common/components/page_wrappe
 import { SpyRoute } from '../../common/utils/route/spy_routes';
 import { LandingLinksImages } from '../components/landing_links_images';
 import { DASHBOARDS_PAGE_TITLE } from './translations';
-import { useAppNavLinks } from '../../common/links';
+import { useAppNavLink } from '../../common/links';
 
 export const DashboardsLandingPage = () => {
-  const dashboardlinks = useAppNavLinks().find(
-    ({ id }) => id === SecurityPageName.dashboardsLanding
-  );
+  const dashboardlinks = useAppNavLink(SecurityPageName.dashboardsLanding);
 
   return (
     <SecuritySolutionPageWrapper>

diff --git a/x-pack/plugins/security_solution/public/landing_pages/pages/manage.tsx b/x-pack/plugins/security_solution/public/landing_pages/pages/manage.tsx
@@ -12,7 +12,7 @@ import styled from 'styled-components';
 import { SecurityPageName } from '../../app/types';
 import { HeaderPage } from '../../common/components/header_page';
 import { SecuritySolutionPageWrapper } from '../../common/components/page_wrapper';
-import { useAppNavLinks } from '../../common/links';
+import { useAppNavLink } from '../../common/links';
 import { NavLinkItem } from '../../common/links/types';
 import { SpyRoute } from '../../common/utils/route/spy_routes';
 import { LandingLinksIcons } from '../components/landing_links_icons';
@@ -39,7 +39,7 @@ const navItemsFromIds = (itemIds: SecurityPageName[], links: NavLinkItem[]) =>
   compact(itemIds.map(getNavItembyId(links)));
 
 export const LandingCategories = React.memo(({ groups }: { groups: LandingNavGroup[] }) => {
-  const manageLink = useAppNavLinks().find(({ id }) => id === SecurityPageName.administration);
+  const manageLink = useAppNavLink(SecurityPageName.administration);
 
   return (
     <>

diff --git a/x-pack/plugins/security_solution/public/landing_pages/pages/threat_hunting.tsx b/x-pack/plugins/security_solution/public/landing_pages/pages/threat_hunting.tsx
@@ -11,12 +11,10 @@ import { SecuritySolutionPageWrapper } from '../../common/components/page_wrappe
 import { SpyRoute } from '../../common/utils/route/spy_routes';
 import { LandingLinksImages } from '../components/landing_links_images';
 import { THREAT_HUNTING_PAGE_TITLE } from './translations';
-import { useAppNavLinks } from '../../common/links';
+import { useAppNavLink } from '../../common/links';
 
 export const ThreatHuntingLandingPage = () => {
-  const threatHuntinglinks = useAppNavLinks().find(
-    ({ id }) => id === SecurityPageName.threatHuntingLanding
-  );
+  const threatHuntinglinks = useAppNavLink(SecurityPageName.threatHuntingLanding);
   return (
     <SecuritySolutionPageWrapper>
       <HeaderPage title={THREAT_HUNTING_PAGE_TITLE} />