Cleanup tsconfig files (#84396) (#84568)

* remove unused "paths" from tsconfig

* remove unused test utils, import get-url from kbn/test

* dont pollute globals with jest when importing getUrl

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

packages/kbn-test/jest-preset.js

@@ -48,7 +48,6 @@ module.exports = {
     '^(!!)?file-loader!': '<rootDir>/packages/kbn-test/target/jest/mocks/file_mock.js',
     '^fixtures/(.*)': '<rootDir>/src/fixtures/$1',
     '^src/core/(.*)': '<rootDir>/src/core/$1',
-    '^src/legacy/(.*)': '<rootDir>/src/legacy/$1',
     '^src/plugins/(.*)': '<rootDir>/src/plugins/$1',
   },
 

packages/kbn-test/src/index.ts

@@ -58,3 +58,5 @@ export { runFailedTestsReporterCli } from './failed_tests_reporter';
 export { CI_PARALLEL_PROCESS_PREFIX } from './ci_parallel_process_prefix';
 
 export * from './functional_test_runner';
+
+export { getUrl } from './jest/utils/get_url';

packages/kbn-test/src/jest/utils/index.ts

@@ -19,6 +19,8 @@
 
 export * from './enzyme_helpers';
 
+export * from './get_url';
+
 export * from './find_test_subject';
 
 export * from './jsdom_svg_mocks';

src/core/tsconfig.json

@@ -14,8 +14,5 @@
     "test_helpers/**/*",
     "utils/**/*",
     "index.ts"
-  ],
-  "references": [
-    { "path": "../test_utils/" }
   ]
 }

src/dev/jest/config.js

@@ -35,7 +35,6 @@ export default {
     '<rootDir>/src/legacy/utils',
     '<rootDir>/src/setup_node_env',
     '<rootDir>/packages',
-    '<rootDir>/src/test_utils',
     '<rootDir>/test/functional/services/remote',
   ],
   testRunner: 'jasmine2',

src/dev/typescript/projects.ts

@@ -27,7 +27,6 @@ export const PROJECTS = [
   new Project(resolve(REPO_ROOT, 'test/tsconfig.json'), { name: 'kibana/test' }),
   new Project(resolve(REPO_ROOT, 'x-pack/tsconfig.json')),
   new Project(resolve(REPO_ROOT, 'x-pack/test/tsconfig.json'), { name: 'x-pack/test' }),
-  new Project(resolve(REPO_ROOT, 'src/test_utils/tsconfig.json')),
   new Project(resolve(REPO_ROOT, 'src/core/tsconfig.json')),
   new Project(resolve(REPO_ROOT, 'x-pack/plugins/security_solution/cypress/tsconfig.json'), {
     name: 'security_solution/cypress',

src/plugins/kibana_utils/tsconfig.json

@@ -16,7 +16,6 @@
     "../../../typings/**/*"
   ],
   "references": [
-    { "path": "../../test_utils/tsconfig.json" },
     { "path": "../../core/tsconfig.json" }
   ]
 }

test/common/services/deployment.ts

@@ -19,8 +19,7 @@
 
 import { get } from 'lodash';
 import fetch from 'node-fetch';
-// @ts-ignore not TS yet
-import getUrl from '../../../src/test_utils/get_url';
+import { getUrl } from '@kbn/test';
 
 import { FtrProviderContext } from '../ftr_provider_context';
 

test/functional/page_objects/common_page.ts

@@ -21,9 +21,8 @@ import { delay } from 'bluebird';
 import expect from '@kbn/expect';
 // @ts-ignore
 import fetch from 'node-fetch';
+import { getUrl } from '@kbn/test';
 import { FtrProviderContext } from '../ftr_provider_context';
-// @ts-ignore not TS yet
-import getUrl from '../../../src/test_utils/get_url';
 
 export function CommonPageProvider({ getService, getPageObjects }: FtrProviderContext) {
   const log = getService('log');

test/functional/page_objects/context_page.ts

@@ -18,9 +18,8 @@
  */
 
 import rison from 'rison-node';
+import { getUrl } from '@kbn/test';
 import { FtrProviderContext } from '../ftr_provider_context';
-// @ts-ignore not TS yet
-import getUrl from '../../../src/test_utils/get_url';
 
 const DEFAULT_INITIAL_STATE = {
   columns: ['@message'],

test/server_integration/http/platform/headers.ts

@@ -18,11 +18,9 @@
  */
 import Http from 'http';
 import Url from 'url';
+import { getUrl } from '@kbn/test';
 import { FtrProviderContext } from '../../services/types';
 
-// @ts-ignore
-import getUrl from '../../../../src/test_utils/get_url';
-
 const delay = (ms: number) => new Promise((resolve) => setTimeout(resolve, ms));
 const oneSec = 1_000;
 

tsconfig.base.json

@@ -6,10 +6,6 @@
       "kibana": ["./kibana"],
       "kibana/public": ["src/core/public"],
       "kibana/server": ["src/core/server"],
-      "plugins/*": ["src/legacy/core_plugins/*/public/"],
-      "test_utils/*": [
-        "src/test_utils/public/*"
-      ],
       "fixtures/*": ["src/fixtures/*"]
     },
     // Support .tsx files and transform JSX into calls to React.createElement

tsconfig.json

@@ -3,7 +3,7 @@
   "compilerOptions": {
     "incremental": false
   },
-  "include": ["kibana.d.ts", "src/**/*", "typings/**/*", "test_utils/**/*"],
+  "include": ["kibana.d.ts", "src/**/*", "typings/**/*"],
   "exclude": [
     "src/**/__fixtures__/**/*",
     "src/core/**/*",
@@ -20,7 +20,6 @@
     "src/plugins/telemetry_collection_manager/**/*",
     "src/plugins/url_forwarding/**/*",
     "src/plugins/usage_collection/**/*",
-    "src/test_utils/**/*"
     // In the build we actually exclude **/public/**/* from this config so that
     // we can run the TSC on both this and the .browser version of this config
     // file, but if we did it during development IDEs would not be able to find
@@ -42,6 +41,5 @@
     { "path": "./src/plugins/telemetry_collection_manager/tsconfig.json" },
     { "path": "./src/plugins/url_forwarding/tsconfig.json" },
     { "path": "./src/plugins/usage_collection/tsconfig.json" },
-    { "path": "./src/test_utils/tsconfig.json" }
   ]
 }