Skip to content

Commit

Permalink
Fix IE specific flexbox min-height issue
Browse files Browse the repository at this point in the history
  • Loading branch information
sulemanof committed May 14, 2020
1 parent 6a3db2c commit 501fe48
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/core/public/rendering/_base.scss
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,10 @@
display: flex;
flex-flow: column nowrap;
margin: 0 auto;
min-height: calc(100vh - #{$euiHeaderHeightCompensation});
// IE needs this to be "height" instead of "min-height"
// "min-height" causes a bug described in the next link
// https://github.com/philipwalton/flexbugs#3-min-height-on-a-flex-container-wont-apply-to-its-flex-items
height: calc(100vh - #{$euiHeaderHeightCompensation});

&.hidden-chrome {
min-height: 100vh;
Expand Down

0 comments on commit 501fe48

Please sign in to comment.