renames 'detections' to 'alerts' (#70164) (#70248)

elastic · Jun 30, 2020 · 57550cf · 57550cf
1 parent 4fe9c73
commit 57550cf
Show file tree

Hide file tree

Showing 11 changed files with 69 additions and 69 deletions.
diff --git a/...on/cypress/integration/detections.spec.ts → ...lution/cypress/integration/alerts.spec.ts b/...on/cypress/integration/detections.spec.ts → ...lution/cypress/integration/alerts.spec.ts
@@ -9,7 +9,7 @@ import {
   SHOWING_ALERTS,
   ALERTS,
   TAKE_ACTION_POPOVER_BTN,
-} from '../screens/detections';
+} from '../screens/alerts';
 
 import {
   closeFirstAlert,
@@ -24,13 +24,13 @@ import {
   waitForAlertsToBeLoaded,
   markInProgressFirstAlert,
   goToInProgressAlerts,
-} from '../tasks/detections';
+} from '../tasks/alerts';
 import { esArchiverLoad } from '../tasks/es_archiver';
 import { loginAndWaitForPage } from '../tasks/login';
 
 import { ALERTS_URL } from '../urls/navigation';
 
-describe('Detections', () => {
+describe('Alerts', () => {
   context('Closing alerts', () => {
     beforeEach(() => {
       esArchiverLoad('alerts');

diff --git a/...ntegration/signal_detection_rules.spec.ts → ...ntegration/alerts_detection_rules.spec.ts b/...ntegration/signal_detection_rules.spec.ts → ...ntegration/alerts_detection_rules.spec.ts
@@ -10,25 +10,25 @@ import {
   RULE_SWITCH,
   SECOND_RULE,
   SEVENTH_RULE,
-} from '../screens/alert_detection_rules';
+} from '../screens/alerts_detection_rules';
 
 import {
-  goToManageAlertDetectionRules,
+  goToManageAlertsDetectionRules,
   waitForAlertsPanelToBeLoaded,
   waitForAlertsIndexToBeCreated,
-} from '../tasks/detections';
-import { esArchiverLoad, esArchiverUnload } from '../tasks/es_archiver';
-import { loginAndWaitForPageWithoutDateRange } from '../tasks/login';
+} from '../tasks/alerts';
 import {
   activateRule,
   sortByActivatedRules,
   waitForLoadElasticPrebuiltDetectionRulesTableToBeLoaded,
   waitForRuleToBeActivated,
-} from '../tasks/alert_detection_rules';
+} from '../tasks/alerts_detection_rules';
+import { esArchiverLoad, esArchiverUnload } from '../tasks/es_archiver';
+import { loginAndWaitForPageWithoutDateRange } from '../tasks/login';
 
 import { ALERTS_URL } from '../urls/navigation';
 
-describe('Detection rules', () => {
+describe('Alerts detection rules', () => {
   before(() => {
     esArchiverLoad('prebuilt_rules_loaded');
   });
@@ -41,7 +41,7 @@ describe('Detection rules', () => {
     loginAndWaitForPageWithoutDateRange(ALERTS_URL);
     waitForAlertsPanelToBeLoaded();
     waitForAlertsIndexToBeCreated();
-    goToManageAlertDetectionRules();
+    goToManageAlertsDetectionRules();
     waitForLoadElasticPrebuiltDetectionRulesTableToBeLoaded();
     cy.get(RULE_NAME)
       .eq(FIFTH_RULE)

diff --git a/...ion/signal_detection_rules_custom.spec.ts → ...ion/alerts_detection_rules_custom.spec.ts b/...ion/signal_detection_rules_custom.spec.ts → ...ion/alerts_detection_rules_custom.spec.ts
@@ -6,6 +6,15 @@
 
 import { newRule, totalNumberOfPrebuiltRulesInEsArchive } from '../objects/rule';
 
+import {
+  CUSTOM_RULES_BTN,
+  RISK_SCORE,
+  RULE_NAME,
+  RULES_ROW,
+  RULES_TABLE,
+  SEVERITY,
+  SHOWING_RULES_TEXT,
+} from '../screens/alerts_detection_rules';
 import {
   ABOUT_FALSE_POSITIVES,
   ABOUT_INVESTIGATION_NOTES,
@@ -28,26 +37,12 @@ import {
   SCHEDULE_RUNS,
   SCHEDULE_STEP,
 } from '../screens/rule_details';
-import {
-  CUSTOM_RULES_BTN,
-  RISK_SCORE,
-  RULE_NAME,
-  RULES_ROW,
-  RULES_TABLE,
-  SEVERITY,
-  SHOWING_RULES_TEXT,
-} from '../screens/alert_detection_rules';
 
 import {
-  createAndActivateRule,
-  fillAboutRuleAndContinue,
-  fillDefineCustomRuleWithImportedQueryAndContinue,
-} from '../tasks/create_new_rule';
-import {
-  goToManageAlertDetectionRules,
+  goToManageAlertsDetectionRules,
   waitForAlertsIndexToBeCreated,
   waitForAlertsPanelToBeLoaded,
-} from '../tasks/detections';
+} from '../tasks/alerts';
 import {
   changeToThreeHundredRowsPerPage,
   deleteFirstRule,
@@ -58,7 +53,12 @@ import {
   selectNumberOfRules,
   waitForLoadElasticPrebuiltDetectionRulesTableToBeLoaded,
   waitForRulesToBeLoaded,
-} from '../tasks/alert_detection_rules';
+} from '../tasks/alerts_detection_rules';
+import {
+  createAndActivateRule,
+  fillAboutRuleAndContinue,
+  fillDefineCustomRuleWithImportedQueryAndContinue,
+} from '../tasks/create_new_rule';
 import { esArchiverLoad, esArchiverUnload } from '../tasks/es_archiver';
 import { loginAndWaitForPageWithoutDateRange } from '../tasks/login';
 
@@ -77,7 +77,7 @@ describe('Detection rules, custom', () => {
     loginAndWaitForPageWithoutDateRange(ALERTS_URL);
     waitForAlertsPanelToBeLoaded();
     waitForAlertsIndexToBeCreated();
-    goToManageAlertDetectionRules();
+    goToManageAlertsDetectionRules();
     waitForLoadElasticPrebuiltDetectionRulesTableToBeLoaded();
     goToCreateNewRule();
     fillDefineCustomRuleWithImportedQueryAndContinue(newRule);
@@ -172,7 +172,7 @@ describe('Deletes custom rules', () => {
     loginAndWaitForPageWithoutDateRange(ALERTS_URL);
     waitForAlertsPanelToBeLoaded();
     waitForAlertsIndexToBeCreated();
-    goToManageAlertDetectionRules();
+    goToManageAlertsDetectionRules();
   });
 
   after(() => {

diff --git a/...ion/signal_detection_rules_export.spec.ts → ...ion/alerts_detection_rules_export.spec.ts b/...ion/signal_detection_rules_export.spec.ts → ...ion/alerts_detection_rules_export.spec.ts
@@ -5,13 +5,13 @@
  */
 
 import {
-  goToManageAlertDetectionRules,
+  goToManageAlertsDetectionRules,
   waitForAlertsIndexToBeCreated,
   waitForAlertsPanelToBeLoaded,
-} from '../tasks/detections';
+} from '../tasks/alerts';
+import { exportFirstRule } from '../tasks/alerts_detection_rules';
 import { esArchiverLoad, esArchiverUnload } from '../tasks/es_archiver';
 import { loginAndWaitForPageWithoutDateRange } from '../tasks/login';
-import { exportFirstRule } from '../tasks/alert_detection_rules';
 
 import { ALERTS_URL } from '../urls/navigation';
 
@@ -35,7 +35,7 @@ describe('Export rules', () => {
     loginAndWaitForPageWithoutDateRange(ALERTS_URL);
     waitForAlertsPanelToBeLoaded();
     waitForAlertsIndexToBeCreated();
-    goToManageAlertDetectionRules();
+    goToManageAlertsDetectionRules();
     exportFirstRule();
     cy.wait('@export').then((xhr) => {
       cy.readFile(EXPECTED_EXPORTED_RULE_FILE_PATH).then(($expectedExportedJson) => {

diff --git a/...gration/signal_detection_rules_ml.spec.ts → ...gration/alerts_detection_rules_ml.spec.ts b/...gration/signal_detection_rules_ml.spec.ts → ...gration/alerts_detection_rules_ml.spec.ts
@@ -6,6 +6,15 @@
 
 import { machineLearningRule, totalNumberOfPrebuiltRulesInEsArchive } from '../objects/rule';
 
+import {
+  CUSTOM_RULES_BTN,
+  RISK_SCORE,
+  RULE_NAME,
+  RULE_SWITCH,
+  RULES_ROW,
+  RULES_TABLE,
+  SEVERITY,
+} from '../screens/alerts_detection_rules';
 import {
   ABOUT_FALSE_POSITIVES,
   ABOUT_MITRE,
@@ -26,35 +35,26 @@ import {
   SCHEDULE_STEP,
   RULE_TYPE,
 } from '../screens/rule_details';
-import {
-  CUSTOM_RULES_BTN,
-  RISK_SCORE,
-  RULE_NAME,
-  RULE_SWITCH,
-  RULES_ROW,
-  RULES_TABLE,
-  SEVERITY,
-} from '../screens/alert_detection_rules';
 
 import {
-  createAndActivateRule,
-  fillAboutRuleAndContinue,
-  fillDefineMachineLearningRuleAndContinue,
-  selectMachineLearningRuleType,
-} from '../tasks/create_new_rule';
-import {
-  goToManageAlertDetectionRules,
+  goToManageAlertsDetectionRules,
   waitForAlertsIndexToBeCreated,
   waitForAlertsPanelToBeLoaded,
-} from '../tasks/detections';
+} from '../tasks/alerts';
 import {
   changeToThreeHundredRowsPerPage,
   filterByCustomRules,
   goToCreateNewRule,
   goToRuleDetails,
   waitForLoadElasticPrebuiltDetectionRulesTableToBeLoaded,
   waitForRulesToBeLoaded,
-} from '../tasks/alert_detection_rules';
+} from '../tasks/alerts_detection_rules';
+import {
+  createAndActivateRule,
+  fillAboutRuleAndContinue,
+  fillDefineMachineLearningRuleAndContinue,
+  selectMachineLearningRuleType,
+} from '../tasks/create_new_rule';
 import { esArchiverLoad, esArchiverUnload } from '../tasks/es_archiver';
 import { loginAndWaitForPageWithoutDateRange } from '../tasks/login';
 
@@ -73,7 +73,7 @@ describe('Detection rules, machine learning', () => {
     loginAndWaitForPageWithoutDateRange(ALERTS_URL);
     waitForAlertsPanelToBeLoaded();
     waitForAlertsIndexToBeCreated();
-    goToManageAlertDetectionRules();
+    goToManageAlertsDetectionRules();
     waitForLoadElasticPrebuiltDetectionRulesTableToBeLoaded();
     goToCreateNewRule();
     selectMachineLearningRuleType();

diff --git a/...n/signal_detection_rules_prebuilt.spec.ts → ...n/alerts_detection_rules_prebuilt.spec.ts b/...n/signal_detection_rules_prebuilt.spec.ts → ...n/alerts_detection_rules_prebuilt.spec.ts
@@ -10,8 +10,13 @@ import {
   RELOAD_PREBUILT_RULES_BTN,
   RULES_ROW,
   RULES_TABLE,
-} from '../screens/alert_detection_rules';
+} from '../screens/alerts_detection_rules';
 
+import {
+  goToManageAlertsDetectionRules,
+  waitForAlertsIndexToBeCreated,
+  waitForAlertsPanelToBeLoaded,
+} from '../tasks/alerts';
 import {
   changeToThreeHundredRowsPerPage,
   deleteFirstRule,
@@ -22,20 +27,15 @@ import {
   waitForLoadElasticPrebuiltDetectionRulesTableToBeLoaded,
   waitForPrebuiltDetectionRulesToBeLoaded,
   waitForRulesToBeLoaded,
-} from '../tasks/alert_detection_rules';
-import {
-  goToManageAlertDetectionRules,
-  waitForAlertsIndexToBeCreated,
-  waitForAlertsPanelToBeLoaded,
-} from '../tasks/detections';
+} from '../tasks/alerts_detection_rules';
 import { esArchiverLoadEmptyKibana, esArchiverUnloadEmptyKibana } from '../tasks/es_archiver';
 import { loginAndWaitForPageWithoutDateRange } from '../tasks/login';
 
 import { ALERTS_URL } from '../urls/navigation';
 
 import { totalNumberOfPrebuiltRules } from '../objects/rule';
 
-describe('Detection rules, prebuilt rules', () => {
+describe('Alerts rules, prebuilt rules', () => {
   before(() => {
     esArchiverLoadEmptyKibana();
   });
@@ -51,7 +51,7 @@ describe('Detection rules, prebuilt rules', () => {
     loginAndWaitForPageWithoutDateRange(ALERTS_URL);
     waitForAlertsPanelToBeLoaded();
     waitForAlertsIndexToBeCreated();
-    goToManageAlertDetectionRules();
+    goToManageAlertsDetectionRules();
     waitForLoadElasticPrebuiltDetectionRulesTableToBeLoaded();
     loadPrebuiltDetectionRules();
     waitForPrebuiltDetectionRulesToBeLoaded();
@@ -76,7 +76,7 @@ describe('Deleting prebuilt rules', () => {
     loginAndWaitForPageWithoutDateRange(ALERTS_URL);
     waitForAlertsPanelToBeLoaded();
     waitForAlertsIndexToBeCreated();
-    goToManageAlertDetectionRules();
+    goToManageAlertsDetectionRules();
     waitForLoadElasticPrebuiltDetectionRulesTableToBeLoaded();
     loadPrebuiltDetectionRules();
     waitForPrebuiltDetectionRulesToBeLoaded();

diff --git a/...s/integration/detections_timeline.spec.ts → ...press/integration/alerts_timeline.spec.ts b/...s/integration/detections_timeline.spec.ts → ...press/integration/alerts_timeline.spec.ts
@@ -4,20 +4,20 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { ALERT_ID } from '../screens/detections';
+import { ALERT_ID } from '../screens/alerts';
 import { PROVIDER_BADGE } from '../screens/timeline';
 
 import {
   expandFirstAlert,
   investigateFirstAlertInTimeline,
   waitForAlertsPanelToBeLoaded,
-} from '../tasks/detections';
+} from '../tasks/alerts';
 import { esArchiverLoad, esArchiverUnload } from '../tasks/es_archiver';
 import { loginAndWaitForPage } from '../tasks/login';
 
 import { ALERTS_URL } from '../urls/navigation';
 
-describe('Detections timeline', () => {
+describe('Alerts timeline', () => {
   beforeEach(() => {
     esArchiverLoad('timeline_alerts');
     loginAndWaitForPage(ALERTS_URL);

diff --git a/...ty_solution/cypress/screens/detections.ts → ...curity_solution/cypress/screens/alerts.ts b/...ty_solution/cypress/screens/detections.ts → ...curity_solution/cypress/screens/alerts.ts
diff --git a/.../cypress/screens/alert_detection_rules.ts → ...cypress/screens/alerts_detection_rules.ts b/.../cypress/screens/alert_detection_rules.ts → ...cypress/screens/alerts_detection_rules.ts
diff --git a/...rity_solution/cypress/tasks/detections.ts → ...security_solution/cypress/tasks/alerts.ts b/...rity_solution/cypress/tasks/detections.ts → ...security_solution/cypress/tasks/alerts.ts
@@ -22,7 +22,7 @@ import {
   OPEN_SELECTED_ALERTS_BTN,
   MARK_ALERT_IN_PROGRESS_BTN,
   MARK_SELECTED_ALERTS_IN_PROGRESS_BTN,
-} from '../screens/detections';
+} from '../screens/alerts';
 import { REFRESH_BUTTON } from '../screens/security_header';
 
 export const closeFirstAlert = () => {
@@ -43,7 +43,7 @@ export const goToClosedAlerts = () => {
   cy.get(CLOSED_ALERTS_FILTER_BTN).click({ force: true });
 };
 
-export const goToManageAlertDetectionRules = () => {
+export const goToManageAlertsDetectionRules = () => {
   cy.get(MANAGE_ALERT_DETECTION_RULES_BTN).should('exist').click({ force: true });
 };
 

diff --git a/...on/cypress/tasks/alert_detection_rules.ts → ...n/cypress/tasks/alerts_detection_rules.ts b/...on/cypress/tasks/alert_detection_rules.ts → ...n/cypress/tasks/alerts_detection_rules.ts
@@ -24,7 +24,7 @@ import {
   SORT_RULES_BTN,
   THREE_HUNDRED_ROWS,
   EXPORT_ACTION_BTN,
-} from '../screens/alert_detection_rules';
+} from '../screens/alerts_detection_rules';
 
 export const activateRule = (rulePosition: number) => {
   cy.get(RULE_SWITCH).eq(rulePosition).click({ force: true });