Skip to content

Commit

Permalink
Merge branch 'master' into misc_ui_followup
Browse files Browse the repository at this point in the history
  • Loading branch information
elasticmachine authored Jul 16, 2020
2 parents 4aac0de + 9ba750e commit 5e90179
Show file tree
Hide file tree
Showing 30 changed files with 357 additions and 132 deletions.
21 changes: 16 additions & 5 deletions packages/kbn-optimizer/src/report_optimizer_stats.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ interface Entry {
stats: Fs.Stats;
}

const IGNORED_EXTNAME = ['.map', '.br', '.gz'];

const getFiles = (dir: string, parent?: string) =>
flatten(
Fs.readdirSync(dir).map((name): Entry | Entry[] => {
Expand All @@ -51,7 +53,19 @@ const getFiles = (dir: string, parent?: string) =>
stats,
};
})
);
).filter((file) => {
const filename = Path.basename(file.relPath);
if (filename.startsWith('.')) {
return false;
}

const ext = Path.extname(filename);
if (IGNORED_EXTNAME.includes(ext)) {
return false;
}

return true;
});

export function reportOptimizerStats(reporter: CiStatsReporter, config: OptimizerConfig) {
return pipeClosure((update$: OptimizerUpdate$) => {
Expand All @@ -70,10 +84,7 @@ export function reportOptimizerStats(reporter: CiStatsReporter, config: Optimize
// make the cache read from the cache file since it was likely updated by the worker
bundle.cache.refresh();

const outputFiles = getFiles(bundle.outputDir).filter(
(file) => !(file.relPath.startsWith('.') || file.relPath.endsWith('.map'))
);

const outputFiles = getFiles(bundle.outputDir);
const entryName = `${bundle.id}.${bundle.type}.js`;
const entry = outputFiles.find((f) => f.relPath === entryName);
if (!entry) {
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/dev_tools/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export class DevToolsPlugin implements Plugin<DevToolsSetup, void> {
}),
updater$: this.appStateUpdater,
euiIconType: 'devToolsApp',
order: 9001,
order: 9010,
category: DEFAULT_APP_CATEGORIES.management,
mount: async (params: AppMountParameters) => {
const { element, history } = params;
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/management/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export class ManagementPlugin implements Plugin<ManagementSetup, ManagementStart
title: i18n.translate('management.stackManagement.title', {
defaultMessage: 'Stack Management',
}),
order: 9003,
order: 9040,
euiIconType: 'managementApp',
category: DEFAULT_APP_CATEGORIES.management,
async mount(params: AppMountParameters) {
Expand Down
3 changes: 2 additions & 1 deletion test/functional/apps/dashboard/dashboard_filter_bar.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ export default function ({ getService, getPageObjects }) {
const browser = getService('browser');
const PageObjects = getPageObjects(['common', 'dashboard', 'header', 'visualize', 'timePicker']);

describe('dashboard filter bar', () => {
// FLAKY: https://github.com/elastic/kibana/issues/71987
describe.skip('dashboard filter bar', () => {
before(async () => {
await esArchiver.load('dashboard/current/kibana');
await kibanaServer.uiSettings.replace({
Expand Down
36 changes: 0 additions & 36 deletions test/functional/apps/management/_create_index_pattern_wizard.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,42 +51,6 @@ export default function ({ getService, getPageObjects }) {
});
});

describe('data streams', () => {
it('can be an index pattern', async () => {
await es.transport.request({
path: '/_index_template/generic-logs',
method: 'PUT',
body: {
index_patterns: ['logs-*', 'test_data_stream'],
template: {
mappings: {
properties: {
'@timestamp': {
type: 'date',
},
},
},
},
data_stream: {
timestamp_field: '@timestamp',
},
},
});

await es.transport.request({
path: '/_data_stream/test_data_stream',
method: 'PUT',
});

await PageObjects.settings.createIndexPattern('test_data_stream', false);

await es.transport.request({
path: '/_data_stream/test_data_stream',
method: 'DELETE',
});
});
});

describe('index alias', () => {
it('can be an index pattern', async () => {
await es.transport.request({
Expand Down
3 changes: 2 additions & 1 deletion test/functional/apps/visualize/_tsvb_chart.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const security = getService('security');
const PageObjects = getPageObjects(['visualize', 'visualBuilder', 'timePicker', 'visChart']);

describe('visual builder', function describeIndexTests() {
// FLAKY: https://github.com/elastic/kibana/issues/71979
describe.skip('visual builder', function describeIndexTests() {
this.tags('includeFirefox');
beforeEach(async () => {
await security.testUser.setRoles([
Expand Down
1 change: 1 addition & 0 deletions x-pack/plugins/ingest_manager/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ export class IngestManagerPlugin
id: PLUGIN_ID,
category: DEFAULT_APP_CATEGORIES.management,
title: i18n.translate('xpack.ingestManager.appTitle', { defaultMessage: 'Ingest Manager' }),
order: 9020,
euiIconType: 'savedObjectsApp',
async mount(params: AppMountParameters) {
const [coreStart, startDeps] = (await core.getStartServices()) as [
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ function getBaseTemplate(
index: {
// ILM Policy must be added here, for now point to the default global ILM policy name
lifecycle: {
name: `${type}-default`,
name: type,
},
// What should be our default for the compression?
codec: 'best_compression',
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ export class MVTSingleLayerSourceSettings extends Component<Props, State> {
label={i18n.translate(
'xpack.maps.source.MVTSingleLayerVectorSourceEditor.layerNameMessage',
{
defaultMessage: 'Tile layer',
defaultMessage: 'Source layer',
}
)}
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ describe('getImmutableSourceProperties', () => {
const source = new MVTSingleLayerVectorSource(descriptor);
const properties = await source.getImmutableProperties();
expect(properties).toEqual([
{ label: 'Data source', value: '.pbf vector tiles' },
{ label: 'Data source', value: 'Vector tiles' },
{ label: 'Url', value: 'https://example.com/{x}/{y}/{z}.pbf' },
]);
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import { ITooltipProperty, TooltipProperty } from '../../tooltips/tooltip_proper
export const sourceTitle = i18n.translate(
'xpack.maps.source.MVTSingleLayerVectorSource.sourceTitle',
{
defaultMessage: '.pbf vector tiles',
defaultMessage: 'Vector tiles',
}
);

Expand Down
Loading

0 comments on commit 5e90179

Please sign in to comment.